Fix [#94] picker view 관련 ms값 가져오기 구현 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-seonwoo
changed the title
Zoe0929
reviewed
Jan 17, 2024
| nextButton.updateStatus(isEnabled: true) | ||
| totalTime = selectedValue | ||
|
|
| @@ -77,7 +77,7 @@ extension HMHTimePickerView: UIPickerViewDelegate { | |||
| self.reloadComponent(component) | |||
| isChanged = true | |||
| selectedValue = Int(timeList[row]) ?? 0 | |||
| self.totalTimePickerDelegate?.updateAvailability(selectedValue: selectedValue) | |||
| self.totalTimePickerDelegate?.updateAvailability(selectedValue: selectedValue, type: type) | |||
|
|
|||
Comment on lines
27
to
29
| self.delegate = self | ||
| goalTimeView.hourPicker.totalTimePickerDelegate = self | ||
| goalTimeView.minPicker.totalTimePickerDelegate = self |
boyeon0119
approved these changes
Jan 17, 2024
| func updateAvailability(selectedValue: Int, type: HMHTimePickerView.TimePickerType) { | ||
| if type == .specificTime { | ||
| self.specificTime = selectedValue | ||
|
|
| nextButton.updateStatus(isEnabled: true) | ||
| let convertedTime = convertHoursAndMinutesToMilliseconds(hours: specificTime, minutes: specificMinute) | ||
| SignUpManager.shared.goalTime = convertedTime | ||
| print(convertedTime) |
| func updateAvailability(selectedValue: Int, type: HMHTimePickerView.TimePickerType) { | ||
| if type == .specificTime { | ||
| self.specificTime = selectedValue | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👾 작업 내용
🚀 PR Point
📸 스크린샷
✅ Issue
Resolved #94