[UI/#33] MyTodo UI 구현 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Jan 8, 2024
Comment on lines
48
to
54
| binding.cbMyTodoUnselected.setOnSingleClickListener { | ||
| itemSelect(position) | ||
| } | ||
|
|
||
| binding.cbMyTodoSelected.setOnSingleClickListener { | ||
| itemUnselect(position) | ||
| } |
There was a problem hiding this comment.
binding.run 내부에 binding이 있네용 ㅎㅎㅎㅎ
수정 부탁드려요~~~
leeeyubin
approved these changes
Jan 8, 2024
Comment on lines
+9
to
+13
| class MyTodoListAdapter( | ||
| private val isCompleted: Boolean, | ||
| private val itemSelect: (Int) -> Unit, | ||
| private val itemUnselect: (Int) -> Unit | ||
| ) : RecyclerView.Adapter<MyTodoListViewHolder>() { |
There was a problem hiding this comment.
파일 이름은 ListAdapter인데 RecyclerView를 상속받은 건가용..?
There was a problem hiding this comment.
MyTodoList / Adapter 느낌,,,
Comment on lines
+29
to
+33
| fun removeItem(position: Int) { | ||
| itemList.removeAt(position) | ||
| notifyItemRemoved(position) | ||
| notifyItemRangeChanged(position, itemCount) | ||
| } |
Comment on lines
+84
to
+86
| android:layout_marginHorizontal="24dp" | ||
| android:text="우쥬랑 스페인" | ||
| app:layout_constraintEnd_toEndOf="parent" |
There was a problem hiding this comment.
아직 서버 안붙여서 구현되면 바꿔둘게용~
Comment on lines
+20
to
+22
| binding.run { | ||
| tvMyTodoItemTitle.text = item.title | ||
| tvMyTodoItemDate.text = item.endDate.replace("-", ".") + "까지" |
crownjoe
approved these changes
Jan 8, 2024
app/src/main/AndroidManifest.xml
Outdated
| @@ -54,7 +54,7 @@ | |||
|
|
|||
| <activity | |||
| android:name="com.going.presentation.todo.TodoActivity" | |||
| android:exported="false" | |||
| android:exported="true" | |||
There was a problem hiding this comment.
pr 올릴 때는 true말고 false로 올려주세요~!!!! ㅎㅎ
|
|
||
| val mockUncompleteTodoList: List<TodoModel> = listOf( | ||
| TodoModel(0, "숙소 예약하기", "2024-01-12", listOf("김상호", "박동민"), false), | ||
| TodoModel(1, "기차 왕복 예약하기", "2024-01-14", listOf("조세연"), false), |
| fun onBind(item: TodoModel, position: Int) { | ||
| binding.run { | ||
| tvMyTodoItemTitle.text = item.title | ||
| tvMyTodoItemDate.text = item.endDate.replace("-", ".") + "까지" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-01-08-23-20-03.mp4
📢 To Reviewers