Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/#30] 여행 대시 보드 뷰 / UI 구현 #42

Merged
merged 29 commits into from
Jan 8, 2024

Conversation

leeeyubin
Copy link
Member

⛳️ Work Description

  • 진행 중인 여행 프래그먼트
  • 완료된 여행 프래그먼트
  • 뷰 페이저 구현
  • 여행 아이템 리사이클러뷰 구현
  • 버튼 클릭 리스너 구현
  • ItemDecoration 구현
  • 하단 투명도 구현

📸 Screenshot

device-2024-01-08-215904.mp4

📢 To Reviewers

  • 에뮬레이터에서는 ripple 효과가 없어지지 않았는데, 실제 핸드폰으로 실행해본 결과 ripple 효과는 잘 없어졌습니다!

@leeeyubin leeeyubin self-assigned this Jan 8, 2024
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머임 개잘함 ㅡㅡ

@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layer-list 는 네이밍 다르게 해주세요 ~

android:id="@+id/vp_dashboard"
android:layout_width="match_parent"
android:layout_height="0dp"
android:layout_weight="1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weight 대신 제약 양쪽 둘다 줘두는게 좋을 듯 합니당

android:layout_width="0dp"
android:layout_height="wrap_content"
android:paddingTop="20dp"
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

방향도 꼭 같이 지정해주세요 ~

android:layout_marginStart="16dp"
android:layout_marginTop="4dp"
android:layout_marginBottom="16dp"
android:text="2024 .03 .24"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요런거는 tools로 !

android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginStart="2dp"
android:text="-"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요런거는 텍스트 추출!

android:paddingHorizontal="8dp"
android:paddingVertical="2dp"
android:text="@string/dashboard_tv_completed_trip"
android:textAppearance="@style/TextAppearance.Doorip.Detail2.Bold"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 대신 style로 지정해주세요~

Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋지다 유비나

좋네요

뷰페이저 마스터하셨네욥

추카드립니다

day = 300
),
OngoingListModel(
title = "세연이랑 바다 구경",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가자


val mockCompletedList: List<CompletedListModel> = listOf(
CompletedListModel(
title = "유빈이 생일 파티",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필참

@leeeyubin leeeyubin merged commit 9e9cd65 into develop Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] 여행 대시 보드 뷰 / UI 구현
3 participants