-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/#30] 여행 대시 보드 뷰 / UI 구현 #42
Conversation
…into ui/#30-trip-dash-board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
머임 개잘함 ㅡㅡ
@@ -0,0 +1,14 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<layer-list xmlns:android="http://schemas.android.com/apk/res/android"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layer-list 는 네이밍 다르게 해주세요 ~
android:id="@+id/vp_dashboard" | ||
android:layout_width="match_parent" | ||
android:layout_height="0dp" | ||
android:layout_weight="1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weight 대신 제약 양쪽 둘다 줘두는게 좋을 듯 합니당
android:layout_width="0dp" | ||
android:layout_height="wrap_content" | ||
android:paddingTop="20dp" | ||
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
방향도 꼭 같이 지정해주세요 ~
android:layout_marginStart="16dp" | ||
android:layout_marginTop="4dp" | ||
android:layout_marginBottom="16dp" | ||
android:text="2024 .03 .24" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요런거는 tools로 !
android:layout_width="wrap_content" | ||
android:layout_height="wrap_content" | ||
android:layout_marginStart="2dp" | ||
android:text="-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요런거는 텍스트 추출!
android:paddingHorizontal="8dp" | ||
android:paddingVertical="2dp" | ||
android:text="@string/dashboard_tv_completed_trip" | ||
android:textAppearance="@style/TextAppearance.Doorip.Detail2.Bold" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 대신 style로 지정해주세요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
멋지다 유비나
좋네요
뷰페이저 마스터하셨네욥
추카드립니다
day = 300 | ||
), | ||
OngoingListModel( | ||
title = "세연이랑 바다 구경", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
가자
|
||
val mockCompletedList: List<CompletedListModel> = listOf( | ||
CompletedListModel( | ||
title = "유빈이 생일 파티", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
필참
⛳️ Work Description
📸 Screenshot
device-2024-01-08-215904.mp4
📢 To Reviewers