[FEAT/#240] tendency intent 분기처리 #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Mar 9, 2024
| @@ -1,5 +1,6 @@ | |||
| package com.going.presentation.onboarding.signup | |||
|
|
|||
| import android.util.Log | |||
Comment on lines
+67
to
+69
| const val TENDENCY = "TENDENCY" | ||
| const val PROFILE = "PROFILE" | ||
| const val QUARTER = "QUARTER" |
There was a problem hiding this comment.
분기처리 실력 ... 진짜 말안되긴 하네요 ... .. . . . .. . . . . .. . . . . 읽으면서 행복함
다만 더 요즘스타일 코드로 가려면 요 세 친구들은 const val 대신 enum으로 처리하면 더 깔끔할듯 !
There was a problem hiding this comment.
QUARTER는 분기처리를 하는게 아니라 Intent의 Key로 넣어주는거라 enum으로 묶는건 안맞을것 같습니다!
하지만 Tendency랑 Profile은 Enum으로 묶어준다면 when문 내부 else도 없애고 더 깔끔해질 것 같네요 :)
조언 채~고~~~~~~~
There was a problem hiding this comment.
이 부분은 제가 요즘 공부하고있는 부분이 있어서 2차 스프린트 끝나고 리펙토링 기간 가지면서 적용해보도록 하겠습니다!
crownjoe
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers