[REFACTOR/#189] 투두 생성, 조회 뷰 통합 & 커스텀뷰 적용 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into refactor/#189-todo-create
chattymin
approved these changes
Feb 26, 2024
Comment on lines
+100
to
+101
| rvOurTodoDetailPerson.visibility = View.INVISIBLE | ||
| layoutMyTodoCreatePerson.visibility = View.VISIBLE |
There was a problem hiding this comment.
저는 isVisible을 사용해서 true, false로 나타내는게 더 직관적으로 느껴지더라구요!
There was a problem hiding this comment.
저도 그렇게 사용합니다만,
isVisible = false의 경우 뷰를 GONE으로 처리해버리기 때문에, invisible 처리를 위해 다음과 같이 작성했습니다 ~
| import kotlinx.coroutines.flow.onEach | ||
|
|
||
| @AndroidEntryPoint | ||
| class TodoCreateActivity : BaseActivity<ActivityTodoCreateBinding>(R.layout.activity_todo_create) { |
leeeyubin
approved these changes
Feb 26, 2024
| import kotlinx.coroutines.flow.onEach | ||
|
|
||
| @AndroidEntryPoint | ||
| class TodoCreateActivity : BaseActivity<ActivityTodoCreateBinding>(R.layout.activity_todo_create) { |
Comment on lines
+139
to
+147
| @JvmStatic | ||
| fun createIntent( | ||
| context: Context, | ||
| todoId: Long, | ||
| isPublic: Boolean, | ||
| ): Intent = Intent(context, TodoDetailActivity::class.java).apply { | ||
| putExtra(EXTRA_TODO_ID, todoId) | ||
| putExtra(EXTRA_IS_PUBLIC, isPublic) | ||
| } |
crownjoe
approved these changes
Feb 26, 2024
Comment on lines
+38
to
+50
|
|
||
| initViewModel() | ||
| setTodoCreateType() | ||
| initDateClickBtnListener() | ||
| initFinishBtnListener() | ||
| initBackBtnListener() | ||
| getTripInfoId() | ||
| setTodoCreateType() | ||
| observeTodoCreateState() | ||
| setEtTodoNameArguments() | ||
| setEtTodoMemoArguments() | ||
| observeNameTextChanged() | ||
| observeMemoTextChanged() |
|
|
||
| class TodoNameAdapter( | ||
| class TodoAllocatorAdapter( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
📢 To Reviewers