[REFACTOR/#185] OurTodo, MyTodo 뷰 / 코드 리팩토링만 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Jan 23, 2024
Comment on lines
+70
to
+74
| MyTodoCreateActivity.createIntent( | ||
| requireContext(), | ||
| viewModel.tripId, | ||
| viewModel.participantId | ||
| ).apply { startActivity(this) } |
There was a problem hiding this comment.
...미쳤다!!>...저도 이거 이용해서 리팩해볼게요 역시 그는 김상호...
Comment on lines
+69
to
+70
| title = todo.value.orEmpty(), | ||
| endDate = endDate.value.orEmpty(), |
Comment on lines
+17
to
+26
| when { | ||
| isCompleted -> { | ||
| setTextColor(binding.root.context.colorOf(R.color.gray_300)) | ||
| setBackgroundResource(R.drawable.shape_rect_2_gray300_line) | ||
| } | ||
|
|
||
| item.isOwner -> { | ||
| setTextColor(binding.root.context.colorOf(R.color.red_500)) | ||
| isSelected = true | ||
| } |
chattymin
approved these changes
Jan 23, 2024
Comment on lines
+70
to
+74
| MyTodoCreateActivity.createIntent( | ||
| requireContext(), | ||
| viewModel.tripId, | ||
| viewModel.participantId | ||
| ).apply { startActivity(this) } |
Comment on lines
+26
to
+30
| tvOurTodoItemTitle.setTextColor(binding.root.context.colorOf(R.color.gray_300)) | ||
| tvOurTodoItemDate.setTextColor(binding.root.context.colorOf(R.color.gray_200)) | ||
| } else { | ||
| tvOurTodoItemTitle.setTextColor(ContextCompat.getColor(binding.root.context,R.color.black_000)) | ||
| tvOurTodoItemDate.setTextColor(ContextCompat.getColor(binding.root.context,R.color.gray_300)) | ||
| tvOurTodoItemTitle.setTextColor(binding.root.context.colorOf(R.color.black_000)) | ||
| tvOurTodoItemDate.setTextColor(binding.root.context.colorOf(R.color.gray_300)) |
There was a problem hiding this comment.
있지만 아무도 안썼던 확장함수들.... 잘 쓰겠습니다 ㅋㅋ
crownjoe
approved these changes
Jan 23, 2024
Comment on lines
+70
to
+74
| MyTodoCreateActivity.createIntent( | ||
| requireContext(), | ||
| viewModel.tripId, | ||
| viewModel.participantId | ||
| ).apply { startActivity(this) } |
There was a problem hiding this comment.
...미쳤다!!>...저도 이거 이용해서 리팩해볼게요 역시 그는 김상호...
Comment on lines
+36
to
+37
| tvMyTodoItemTitle.setTextColor(binding.root.context.colorOf(R.color.gray_300)) | ||
| tvMyTodoItemDate.setTextColor(binding.root.context.colorOf(R.color.gray_200)) |
…into refactor/#185-todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
val inflater by lazy { LayoutInflater.from(parent.context) }활용📢 To Reviewers