Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOVE/#110] 유빈 담당 뷰 / 패키지 재구성 #116

Merged
merged 9 commits into from
Jan 14, 2024

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Jan 14, 2024

⛳️ Work Description

  • 담당 뷰 패키징 재구성하기
  • 대시보드 Empty 뷰 수정하기
  • 리사이클러뷰 이슈 수정하기
  • 여행 친구 조회 뷰 프로그레스바 수정하기

📸 Screenshot

📢 To Reviewers

  • 패키지 재구성하고 대시보드 Empty 뷰 고쳤습니다!
  • 뷰 페이저 버튼 누를 때마다 통신하는 로직으로도 수정했습니다

@leeeyubin leeeyubin added 유빈 ❄ FEAT ✨ 새로운 기능 구현 MOVE 🚚 프로젝트 내 파일이나 코드의 이동 labels Jan 14, 2024
@leeeyubin leeeyubin self-assigned this Jan 14, 2024
@leeeyubin leeeyubin changed the title [MOVE/#110] 유빈 담당 뷰 / 패키지 재구 [MOVE/#110] 유빈 담당 뷰 / 패키지 재구성 Jan 14, 2024
Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Copy link
Contributor

@crownjoe crownjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~~~~~~~~~~~~~

Comment on lines 9 to 16
//
// @POST("api/trips")
// suspend fun postTripInfoFromServer(
// @Body request: EnterPreferenceRequestDto,
// ): BaseResponse<EnterPreferenceResponseDto>
//
//}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skrr...왓츠업

@@ -1,6 +1,7 @@
package com.going.presentation.dashboard.triplist.ongoing

import android.os.Bundle
import android.util.Log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

띠용!

@leeeyubin leeeyubin merged commit 350cd13 into develop Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT ✨ 새로운 기능 구현 MOVE 🚚 프로젝트 내 파일이나 코드의 이동 유빈 ❄
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MOVE] 유빈 담당 뷰 / 패키징 재구성
3 participants