Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOVE/#109] 세연 담당 뷰 패키징 재구성 #112

Merged
merged 6 commits into from
Jan 14, 2024

Conversation

crownjoe
Copy link
Contributor

⛳️ Work Description

  • 패키징 수정

📢 To Reviewers

  • 수정 완료

@crownjoe crownjoe added the MOVE 🚚 프로젝트 내 파일이나 코드의 이동 label Jan 14, 2024
@crownjoe crownjoe self-assigned this Jan 14, 2024
Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요!!!! LGTM~

android:name="com.going.presentation.entertrip.starttrip.StartTripSplashActivity"
android:exported="false"
android:name="com.going.presentation.entertrip.StartTripSplashActivity"
android:exported="true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에헴,,,,

Comment on lines +17 to +22

@POST("/api/trips/{tripId}/entry")
suspend fun postStartInviteTrip(
@Path("tripId") tripId: Long,
@Body request: StartInviteTripRequestDto,
): BaseResponse<StartInviteTripResponseDto>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오! 수고하셨어용

Comment on lines +9 to +12
import com.going.presentation.entertrip.createtrip.choosedate.EnterTripActivity.Companion.END
import com.going.presentation.entertrip.createtrip.choosedate.EnterTripActivity.Companion.START
import com.going.presentation.entertrip.createtrip.choosedate.EnterTripActivity.Companion.TITLE
import com.going.presentation.entertrip.createtrip.choosedate.EnterTripActivity.Companion.TRIP_ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

폴더링 수고하셨습니둥

Copy link
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@@ -5,6 +5,7 @@ import android.content.Intent
import android.os.Bundle
import android.os.Handler
import android.os.Looper
import android.util.Log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지워줏셋욧

@crownjoe crownjoe merged commit 56437db into develop Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MOVE 🚚 프로젝트 내 파일이나 코드의 이동
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MOVE] 세연 담당 뷰 / 패키징 재구성
4 participants