Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(photovoltaic-modules): Energy generation during day fix #950

Merged
merged 4 commits into from
Jan 3, 2025
Merged

fix(photovoltaic-modules): Energy generation during day fix #950

merged 4 commits into from
Jan 3, 2025

Conversation

chriptus13
Copy link
Contributor

@chriptus13 chriptus13 commented Jan 2, 2025 •
edited
Loading

Issue: #562

Description

  • Adjust photovoltaic modules to generate energy during whole sunny day
  • Use correct level day/night values
  • Do not generate energy at all during night

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Rover656
Rover656 requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this in-game shortly, but code wise I only have a single comment. Looking good, and thank you!

...hines/src/main/java/com/enderio/machines/common/blockentity/solar/SolarPanelBlockEntity.java Outdated Show resolved Hide resolved
@chriptus13 chriptus13 requested a review from Rover656 January 2, 2025 16:02
@chriptus13
fix(photovoltaic-modules): energy generation during day fix
32e5432 
Adjust photovoltaic modules to generate energy during whole sunny day;
Use correct level day/night values;
Do not generate energy at all during night.
@chriptus13
docs(photovoltaic-modules): add javadoc to SolarPanelBlockEntity::get…
4d268f2 
…GenerationRate

refactor(photovoltaic-modules): little optimization
@chriptus13
refactor(photovoltaic-modules): extract constants
a9c8ceb
@chriptus13 chriptus13 force-pushed the fix/photovoltaic-modules-generation branch from eed0c02 to a9c8ceb Compare January 3, 2025 20:59
Rover656
Rover656 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The daytime and nighttime detection seems to look good to me after a quick test. Thanks a lot!

@Rover656 Rover656 merged commit ece5afa into Team-EnderIO:dev/1.21.1 Jan 3, 2025
1 check passed
@chriptus13 chriptus13 deleted the fix/photovoltaic-modules-generation branch January 3, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rover656 Rover656 Rover656 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chriptus13 @Rover656