-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Experience Calculation logic #547
Rework Experience Calculation logic #547
Conversation
I have also tried to clean function names, but it still requires some work. Let me know if you would like me to change docs/names |
#363 will require an update if this PR is merged first (else the other way around) |
If the fluid xp use int type can only contain about 4000 levels. maybe it's a problem? |
Maybe it is smart to switch to long in some places, similarly to #329 |
Overflows should not happen anymore, as we don't use recursions anymore. Switching to long may not fix anything as vanilla max level is an INT |
Stack overflows are avoided, yes however if we overflow an integer then we might find ourselves dealing with weird negatives |
I will change the places where we store raw experience points into longs. The levels need to stay as an integer so that it is compatible with vanilla. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a lot to both chonky and GotoFinal for working on this issue!
Description
Changes the xp calculations to remove recursive calls and use much straightforward formulae
(Closes issues indirectly by removing all stack overflow recursions)
Closes #543
Closes #313