-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turnOffResetLogic() -- allow partial reset #207
Comments
@vzahradnik Can you please try the following when you get a moment:
|
Reset functionality is partially OK. Menu hierarchy stays intact and stays at the latest nested screen. However, I was not able to get the notification about menu reset. Here is the code I put together: renderer.resetNotifiesOnly(10); // 10 seconds
renderer.setResetCallback([] {
Log.noticeln("Menu was reset");
}); I'm just assuming that I should use the same callback as with the full menu reset. |
I can confirm the issue persists with the latest TcMenu release. The // TcMenu Bug: renderer.resetNotifiesOnly(storeManager.getDisplay().getDisplayIdleTimeout() * 60);
renderer.setResetIntervalTimeSeconds(storeManager.getDisplay().getDisplayIdleTimeout() * 60);
renderer.setResetCallback([](){
if (storeManager.getDisplay().shouldTurnOffDisplayWhenInactive() && displayManager.isTurnedOn()) {
Log.traceln(F(TC_I18N_DISPLAY_INACTIVITY_TURN_OFF));
displayManager.turnOff();
}
}); |
Is your feature request related to a problem? Please describe.
In the current implementation, TcMenu resets menu after 30 seconds of inactivity. If a user is in some nested menu, after waking up the display, he is presented with the top menu once again. This is not always what we want, yet we would like to use the reset callback to implement our logic.
Please add an option to keep the menu reset logic enabled but without resetting the menu hierarchy to the top level. So that users can react to the event - like turn off a display - and restore the display later.
Currently, I'm calling the code
renderer.turnOffResetLogic();
and implement my own custom logic.The text was updated successfully, but these errors were encountered: