#436 more UI automated testing

TcMenu · Dec 31, 2023 · a2b037b · a2b037b
1 parent c4581e9
commit a2b037b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 8 deletions.
diff --git a/tcMenuGenerator/scripts/packager-all-platforms.md b/tcMenuGenerator/scripts/packager-all-platforms.md
@@ -30,7 +30,7 @@ Drop to a command-line, in the tcMenu/tcMenuGenerator directory and run a maven
 
 Run and smoke test, ensure you are in the tcMenuGenerator/target/jfx/app directory:
 
-    java --module-path ../deps "-Dprism.lcdtext=false" --add-modules com.thecoderscorner.tcmenu.menuEditorUI com.thecoderscorner.menu.editorui.cli.TcMenuDesignerCmd
+    java --module-path ../deps "-Dprism.lcdtext=false" "-Doverride.core.plugin.dir=." --add-modules com.thecoderscorner.tcmenu.menuEditorUI com.thecoderscorner.menu.editorui.cli.TcMenuDesignerCmd
 
 ## Packaging - Build the package - Windows all versions
 

diff --git a/tcMenuGenerator/src/main/java/com/thecoderscorner/menu/editorui/uimodel/UIEnumMenuItem.java b/tcMenuGenerator/src/main/java/com/thecoderscorner/menu/editorui/uimodel/UIEnumMenuItem.java
@@ -45,6 +45,10 @@ protected Optional<EnumMenuItem> getChangedMenuItem() {
             errors.add(new FieldError(bundle.getString("menu.editor.enum.fmt.error"), "Choices"));
         }
 
+        if(localHandler.isLocalSupportEnabled()) {
+            checkListValuesAreInResources(listView.getItems(), errors);
+        }
+
         EnumMenuItemBuilder builder = EnumMenuItemBuilder.anEnumMenuItemBuilder().withExisting(getMenuItem());
         builder.withEnumList(items);
         getChangedDefaults(builder, errors);

diff --git a/tcMenuGenerator/src/main/java/com/thecoderscorner/menu/editorui/uimodel/UIMenuItem.java b/tcMenuGenerator/src/main/java/com/thecoderscorner/menu/editorui/uimodel/UIMenuItem.java
@@ -644,5 +644,15 @@ public String toString() {
         }
     }
 
+    protected void checkListValuesAreInResources(ObservableList<String> items, List<FieldError> errors) {
+        var itemsNotInResources = items.stream()
+                .filter(item -> item.startsWith("%") && !item.startsWith("%%") && item.length() > 1)
+                .filter(item -> localHandler.getLocalSpecificEntry(item.substring(1)) == null)
+                .collect(Collectors.joining(", "));
+        errors.add(new FieldError(bundle.getString("menu.editor.core.locale.missing") + " " +  itemsNotInResources,
+                "List values", false));
+    }
+
+
     public record ControlButtons(Button addButton, Button removeButton) { }
 }
diff --git a/...erator/src/main/java/com/thecoderscorner/menu/editorui/uimodel/UIRuntimeListMenuItem.java b/...erator/src/main/java/com/thecoderscorner/menu/editorui/uimodel/UIRuntimeListMenuItem.java
@@ -26,7 +26,6 @@
 import java.util.List;
 import java.util.Optional;
 import java.util.function.BiConsumer;
-import java.util.stream.Collectors;
 
 import static com.thecoderscorner.menu.domain.RuntimeListMenuItem.ListCreationMode;
 
@@ -62,12 +61,7 @@ protected Optional<RuntimeListMenuItem> getChangedMenuItem() {
         }
 
         if(creationModeCombo.getValue() != ListCreationMode.CUSTOM_RTCALL && localHandler.isLocalSupportEnabled()) {
-            var itemsNotInResources = listView.getItems().stream()
-                    .filter(item -> item.startsWith("%") && !item.startsWith("%%") && item.length() > 1)
-                    .filter(item -> localHandler.getLocalSpecificEntry(item.substring(1)) == null)
-                    .collect(Collectors.joining(", "));
-            errors.add(new FieldError(bundle.getString("menu.editor.core.locale.missing") + " " +  itemsNotInResources,
-                    "List values", false));
+            checkListValuesAreInResources(listView.getItems(), errors);
         }
 
         builder.withInitialRows(initialRowsSpinner.getValue());