Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to disable log truncation on each run #253

Merged
merged 4 commits into from
Apr 17, 2021
Merged

Add support to disable log truncation on each run #253

merged 4 commits into from
Apr 17, 2021

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 16, 2021

This solves a problem that different runs overwrite logs that user is having.

    "logging": {
        "append": true
    },

Fixes #231

@glensc glensc self-assigned this Apr 16, 2021
@glensc glensc mentioned this pull request Apr 16, 2021
Closed
@BEisem
Copy link

BEisem commented Apr 16, 2021

This works as expected. Thank you!

Taxel
Taxel reviewed Apr 17, 2021
View reviewed changes
plex_trakt_sync/config.py Outdated Show resolved Hide resolved
@glensc
Load defaults from default_config_file only
f94bc56 
This removes the need to duplicate settings in code and json file
@glensc glensc merged commit f0fef2c into Taxel:0.7.x Apr 17, 2021
@glensc glensc deleted the logging-truncate-config branch April 17, 2021 09:35
@glensc glensc mentioned this pull request Apr 17, 2021
Merged
Repository owner locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Taxel Taxel Taxel left review comments

Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glensc @BEisem @Taxel