Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --show option to sync, to sync only specific show #247

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 16, 2021

Usage:

./plex_trakt_sync.sh sync --show='The Addams Family (1964)'

requires:

@glensc glensc self-assigned this Apr 16, 2021
@glensc glensc force-pushed the show-by-name-syncing branch from 9054ab7 to c640c52 Compare April 16, 2021 11:53
@glensc glensc added the tested label Apr 16, 2021
@glensc glensc merged commit f784a0e into Taxel:0.7.x Apr 16, 2021
@glensc glensc deleted the show-by-name-syncing branch April 16, 2021 11:59
@BEisem
Copy link

BEisem commented Apr 16, 2021

I'm not sure if this is where you wanted me to comment ... my suggestion to add an error when a show is not found, I didn't mean to add it at the beginning. I meant to add it when the script exits. So for example, if I do:

bink@Homey-McPlexFace plex-trakt-sync-ep-lookup-quick % ./plex_trakt_sync.sh sync --show "Whose Line Is It Anyways"
INFO: Syncing with Plex BlaEis and Trakt binkatl
INFO: Syncing Show: Whose Line Is It Anyways
INFO: Loaded Trakt lists in 3.1 seconds
INFO: Server version 1.22.2.4282-a97b03fad updated at: 2021-04-16 06:24:29
INFO: Recently added: [<Movie:123435:Billy-Connolly:-Live>, <Movie:198356:The-Courier>, <Movie:198354:Heathers>, <Movie:198349:All-Dogs-Go-to-Heave>, <Movie:198347:Ninja-III:-The-Domin>]
INFO: Updated plex watchlist in 0.0 seconds
INFO: Completed full sync in 5.1 seconds

I purposely misspelled the title. It must have (internally) searched for the show, and not found it, right? It reports "Completed full sync in 5.1 seconds" before exiting. I think instead of doing that, it should say something about not being able to find the show "Whose Line Is It Anyways" ... I guess it's a minor thing, but I think it would be a bit more descriptive.

@glensc
Copy link
Collaborator Author

glensc commented Apr 16, 2021

@BEisem noted!

however, it's difficult to implement nicely with the current code, as the --show is a hint (the value is not looked up when show variable is created).

so, I'll leave this as a low priority, to be implemented in the future.

EDIT: Draft PR: #249

Repository owner locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants