Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrobbling support to watch command #192

Merged
merged 12 commits into from
Apr 6, 2021

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Apr 6, 2021

Builds on top of #148

This is mostly proof of concept (but it works!), therefore no readme update.

There's plenty of to optimize:

  • skip events, in case laptop suspend/resume there's tons of messages from websocket that should be skipped
  • code refactoring, isolate logic to own classes/methods/functions
  • optimize on cpu, needs investigating what first
  • the code is synchronous, maybe need to rewrite asynchronous
  • the sleep(1) maybe is putting too much pressure on cpu
  • scrobblng probably needs to emitted only on start/pause/stop, as trakt can itself continue counting play time
  • optimize for reducing requests to trakt
  • it doesn't start scobbing before play is 1%, this is traktpy implementation problem
  • ... that's already a bunch!

NOTE: The Trakt app may need scrobble permission:

@glensc glensc self-assigned this Apr 6, 2021
@glensc glensc merged commit 4a547ad into Taxel:main Apr 6, 2021
@glensc glensc deleted the scrobbling-listener branch April 6, 2021 18:34
Repository owner locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant