-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add PlexApi class for dealing with Plex Api fetching and caching #142
Conversation
Another extract, only implemented few methods, to get acquainted with the usage pattern. so the next method implementation would go smoother. |
6a7d9ef
to
15c8ca0
Compare
This is to avoid dependency loop
@twolaw @Taxel can we get this merged? this and tons of other PR's prevent me from making more changes. and I don't want to make the changes to the old codebase where everything is in one big unmaintainable file. |
@twolaw @Taxel since the review and approval is taking way too long, and @Taxel doesn't respond to lift the 1 approve the rule, perhaps I merge the new things to "develop" branch, and then for release use the existing "master" branch? i.e use the git-flow model. I have tons of things I want to accomplish, but getting things merging here is very painful here. I'm still struggling here to get changes I made 25 days ago:
@twolaw are you ok with this? |
also, can't even merge bugfixes: maybe besides the "develop" branch, switch to "main" branch, until @Taxel is able to remove the 1 approval rule. |
merging to |
Extracted from #122
The purpose of the API class is to make API access fluent, without having to dea with cache_disabled wrapping or thinking if method calls should be cached.
This class makes heavy use of decorators to simplify the code itself.