Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add PlexApi class for dealing with Plex Api fetching and caching #142

Merged
merged 9 commits into from
Apr 4, 2021

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Mar 19, 2021

Extracted from #122

The purpose of the API class is to make API access fluent, without having to dea with cache_disabled wrapping or thinking if method calls should be cached.

This class makes heavy use of decorators to simplify the code itself.

@glensc glensc requested a review from simonc56 March 19, 2021 23:30
@glensc glensc self-assigned this Mar 19, 2021
@glensc
Copy link
Collaborator Author

glensc commented Mar 19, 2021

Another extract, only implemented few methods, to get acquainted with the usage pattern. so the next method implementation would go smoother.

@glensc glensc force-pushed the plex-api branch 2 times, most recently from 6a7d9ef to 15c8ca0 Compare March 20, 2021 14:38
@glensc
Copy link
Collaborator Author

glensc commented Mar 22, 2021

@twolaw @Taxel can we get this merged? this and tons of other PR's prevent me from making more changes. and I don't want to make the changes to the old codebase where everything is in one big unmaintainable file.

@glensc
Copy link
Collaborator Author

glensc commented Mar 25, 2021

@twolaw @Taxel since the review and approval is taking way too long, and @Taxel doesn't respond to lift the 1 approve the rule, perhaps I merge the new things to "develop" branch, and then for release use the existing "master" branch? i.e use the git-flow model.

I have tons of things I want to accomplish, but getting things merging here is very painful here.

I'm still struggling here to get changes I made 25 days ago:

@twolaw are you ok with this?

@glensc
Copy link
Collaborator Author

glensc commented Mar 28, 2021

also, can't even merge bugfixes:

maybe besides the "develop" branch, switch to "main" branch, until @Taxel is able to remove the 1 approval rule.

@glensc glensc changed the base branch from master to main April 4, 2021 17:50
@glensc
Copy link
Collaborator Author

glensc commented Apr 4, 2021

merging to main to get things going:

@glensc glensc merged commit da99895 into Taxel:main Apr 4, 2021
@glensc glensc deleted the plex-api branch April 4, 2021 17:54
Repository owner locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant