New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `-Wreturn-type` and `-Wunused-parameter` warnings in tests. NFC. #98

Open

Quuxplusone wants to merge 3 commits into TartanLlama:master from Quuxplusone:fix-warnings

Quuxplusone commented Jan 2, 2022

Note that or_else::[extensions.or_else] still has an unused variable:

auto failptr = [](eptr e) { return tl::expected<int,eptr>(tl::unexpect, std::move(e));};

but I didn't remove it because it looks like it probably indicates some missing test coverage.

Quuxplusone added 3 commits

January 2, 2022 13:39


          Fix a couple of -Wreturn-type warnings in tests. NFC.

c148f52


          Fix -Wunused-parameter warnings in tests. NFC.

1ea24d8


          Fix a -Wunused-value warning in a test. NFC.

2bca148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet