Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFINAE-friendly and_then and map #101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SFINAE-friendly and_then and map #101

wants to merge 5 commits into from

Commits on Jan 2, 2022

  1. Prepare and_then/map/transform/map_error/or_else for SFINAE-friendlin… 

    …ess.

This incidentally simplifies the preprocessor stuff, by making these
codepaths look the same in both C++11 and C++14. The old code had the
weird effect that the C++11 codepath was slightly *more* SFINAE-friendly
than the C++14 codepath.

This patch doesn't actually make and_then/map/transform/map_error/or_else
be SFINAE-friendly. But it lays the groundwork for adding further
constraints to the `enable_if` stuff in `and_then_impl` etc., which
could make these functions fully SFINAE-friendly without needing to
touch the non-`_impl` versions again.
    @Quuxplusone
    Quuxplusone committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    d420c97 View commit details
    Browse the repository at this point in the history

  2. Move and_then_impl above its first use; ADL-proof its use. 

    This mainly just swaps two big blocks of code. But it also
adds `detail::` in front of every call to `foo_impl`; and
it renames `expected_map_impl` to simply `map_impl` because
that seems more consistent with the rest of the names.
    @Quuxplusone
    Quuxplusone committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    05f4c98 View commit details
    Browse the repository at this point in the history

  3. SFINAE-friendly and_then

    @Quuxplusone
    Quuxplusone committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    0258ed6 View commit details
    Browse the repository at this point in the history

  4. Add some simple tests for expected<void,E>::map.

    @Quuxplusone
    Quuxplusone committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    103bfdb View commit details
    Browse the repository at this point in the history

  5. SFINAE-friendly map

    @Quuxplusone
    Quuxplusone committed Jan 2, 2022
    Configuration menu
    Copy the full SHA
    fa31642 View commit details
    Browse the repository at this point in the history