Commit some added safety and logging

frosthaven_assistant_server/lib/connection_health.dart

@@ -0,0 +1,34 @@
+class ConnectionHealth{
+  DateTime creation = DateTime.now();
+  int pingsSent = 0;
+  int pongsReceived = 0;
+  DateTime? lastMessageSent;
+  DateTime? lastMessageReceived;
+  int messageSent = 0;
+  int messageRecieved = 0;
+
+  logPing(){
+    pingsSent ++;
+    lastMessageSent = DateTime.now();
+  }
+
+  logPong(){
+    pongsReceived ++;
+    lastMessageReceived = DateTime.now();
+  }
+
+  logMessageSent(){
+    messageSent ++;
+    lastMessageSent = DateTime.now();
+  }
+
+  logMessageReceived(){
+    messageRecieved ++;
+    lastMessageReceived = DateTime.now();
+  }
+
+  @override
+  String toString() {
+    return "Created: $creation Sent: $lastMessageSent Recieved: $lastMessageReceived pings $pongsReceived/$pingsSent messages $messageSent | $messageRecieved";
+  }
+}

frosthaven_assistant_server/lib/game_server.dart

@@ -13,7 +13,7 @@ class StateUpdateMessage {
 
 abstract class GameServer {
 
-  final int serverVersion = 190;
+  final int serverVersion = 191;
 
   ServerSocket? _serverSocket;
   ServerSocket? get serverSocket {
@@ -122,14 +122,18 @@ abstract class GameServer {
     resetState();
   }
 
-  void handleConnection(Socket client) {
-    client.setOption(SocketOption.tcpNoDelay, true);
-    client.encoding = utf8;
-
+  void logHandleConnection(Socket client){
     String info = 'Connection from'
         ' ${client.remoteAddress.address}:${client.remotePort}';
     log(info);
     setNetworkMessage(info);
+  }
+
+  void handleConnection(Socket client) {
+    client.setOption(SocketOption.tcpNoDelay, true);
+    client.encoding = utf8;
+
+    logHandleConnection(client);
 
     addClientConnection(client);
 

frosthaven_assistant_server/lib/server_state.dart

@@ -29,7 +29,12 @@ class ServerState {
       print('server sends, undo index: $commandIndex, description:${commandDescriptions[commandIndex]}');
       //should send a special undo message? yes
       commandIndex--;
-      return "Index:${commandIndex}Description:${commandDescriptions[commandIndex]}GameState:${gameSaveStates[commandIndex]!.getState()}";
+      if (commandIndex >= 0){
+        return "Index:${commandIndex}Description:${commandDescriptions[commandIndex]}GameState:${gameSaveStates[commandIndex]!.getState()}";
+      } else {
+        commandIndex = 0;
+        return "";
+      }
     }
     return "";
   }

frosthaven_assistant_server/lib/standalone_server.dart

@@ -2,17 +2,22 @@
 import 'dart:developer';
 import 'dart:io';
 
+import 'package:frosthaven_assistant_server/connection_health.dart';
 import 'package:frosthaven_assistant_server/game_server.dart';
 import 'package:frosthaven_assistant_server/server_state.dart';
 
 class StandaloneServer extends GameServer {
 
   final List<Socket> _clientConnections = List.empty(growable: true);
   final ServerState _state = ServerState();
+  final Map<Socket,ConnectionHealth> _connectionHealth = {};
+  int pingCount = 0;
 
 
   @override
   void addClientConnection(Socket client) {
+    print("Add client connection ${safeGetClientAddress(client)}");
+    _connectionHealth[client] = ConnectionHealth();
     _clientConnections.add(client);
   }
 
@@ -45,15 +50,27 @@ class StandaloneServer extends GameServer {
 
   @override
   void removeAllClientConnections() {
+    print("Remove all Client Connections");
     for (var client in _clientConnections) {
-      client.close();
+      print("Close Connection ${safeGetClientAddress(client)} ${_connectionHealth[client]}");
+      try {
+        client.close();
+      } catch (exception) {
+        print("Client already closed");
+      }
     }
     _clientConnections.clear();
   }
 
   @override
   void removeClientConnection(Socket client) {
-    client.close();
+    print("Remove client connection ${safeGetClientAddress(client)}");
+    print("Close Connection ${safeGetClientAddress(client)} ${_connectionHealth[client]}");
+    try {
+      client.close();
+    } catch (exception) {
+      print("Client already closed");
+    }
     _clientConnections.remove(client);
   }
 
@@ -102,14 +119,19 @@ class StandaloneServer extends GameServer {
   void sendToOthers(String data, Socket client) {
     final String message = _createMessage(data);
     for(Socket clientConnection in _clientConnections){
-      if (client.remoteAddress != clientConnection.remoteAddress || clientConnection.remotePort != client.remotePort){
-        _writeToClient(clientConnection, message);
+      try {
+        if (client.remoteAddress != clientConnection.remoteAddress || clientConnection.remotePort != client.remotePort){
+          _writeToClient(clientConnection, message);
+        }
+      } catch (exception) {
+        print("Attempted to access properties on a closed client $exception");
       }
     }
   }
 
   void _writeToClient(Socket client, String message) {
     try {
+      _connectionHealth[client]?.logMessageSent();
       client.write(message);
     } catch (error) {
       print(error);
@@ -126,6 +148,8 @@ class StandaloneServer extends GameServer {
     String message = _state.undoState();
     if (message.isNotEmpty) {
       send(message);
+    } else {
+      setNetworkMessage("Unable to undo command");
     }
   }
 
@@ -166,15 +190,58 @@ class StandaloneServer extends GameServer {
     if (serverSocket != null && serverEnabled) {
       Future.delayed(const Duration(seconds: 5), () {
         send("ping");
+        for(Socket client in _clientConnections){
+          _connectionHealth[client]?.logPing();
+        }
+        pingCount ++;
+        if (pingCount % 30 == 0){
+          printHealthReport();
+        }
         sendPing();
       });
     }
   }
 
+  @override
+  void handlePongMessage(Socket client){
+    super.handlePongMessage(client);
+    _connectionHealth[client]?.logPong();
+  }
+
+  @override
+  void processMessages(String socketMessages, Socket client){
+    _connectionHealth[client]?.logMessageReceived();
+    super.processMessages(socketMessages, client);
+  }
+
   String _createMessage(String data){
     const beginning = "S3nD:";
     const end = "[EOM]";
     return "$beginning$data$end";
   }
+
+  void printHealthReport(){
+    print("=======================================");
+    print("|           HEALTH REPORT             |");
+    print("=======================================");
+    print("ACTIVE CONNNECTIONS: ${_clientConnections.length}");
+    for(Socket client in _clientConnections){
+      print("Client ${safeGetClientAddress(client)} ${_connectionHealth[client]}");
+    }
+    print("");
+    print("TOTAL CONNECTIONS: ${_connectionHealth.keys.length}");
+    print("HEALTH DATA: ");
+    for (ConnectionHealth data in _connectionHealth.values){
+      print(data);
+    }
+  }
+
+  String safeGetClientAddress(Socket client){
+    try{
+      return "Client ${client.remoteAddress}:${client.remotePort}";
+    } catch (exception) {
+      return "Closed client: ";
+    }
+  }
 
 }