Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim workaround (issue #77) #78

Merged
merged 3 commits into from
Nov 21, 2020
Merged

trim workaround (issue #77) #78

merged 3 commits into from
Nov 21, 2020

Conversation

pchalamet
Copy link
Contributor

This is a workaround for issue #77 as describe in dotnet/runtime#43222 (comment)
Publish with trimming now works as expected.

This PR convert Serializer.Serialize<> and Serializer.Deserialize<> to non-generic counterparts.

NOTE: no performance impact has been done. This probably ought be checked (downcast :?> used).

@pchalamet
Copy link
Contributor Author

Merged main.
Looks good with your changes on master.
Thanks.

@Tarmil
Copy link
Owner

Tarmil commented Nov 21, 2020

After testing some more, it seems that only the calls parameterized by 'T[] are problematic; the ones parameterized by 'T or even seq<'T> can remain generic. And looking at this, there is definitely a performance impact for using the non-generic version at least for structs. So I'll merge the change only for 'T[].

@Tarmil Tarmil merged commit e00474a into Tarmil:master Nov 21, 2020
@pchalamet pchalamet deleted the feature/trim-workaround branch November 21, 2020 14:51
@pchalamet
Copy link
Contributor Author

Thanks for the feedback. Good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants