Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record deserialization throws NRE if ignore null values is on #164

Closed
mlaily opened this issue Jul 5, 2023 · 0 comments · Fixed by #166
Closed

Record deserialization throws NRE if ignore null values is on #164

mlaily opened this issue Jul 5, 2023 · 0 comments · Fixed by #166
Labels
bug Something isn't working

Comments

@mlaily
Copy link

mlaily commented Jul 5, 2023 •
edited
Loading

Hello!

It seems there is some issue with the JsonRecordConverter: when ignoreNullValues is on (e.g. set with option DefaultIgnoreCondition = Serialization.JsonIgnoreCondition.WhenWritingNull), attempting to deserialize an empty json object throws a NullReferenceException.

I'm not sure how to fix this properly, but I managed to add a failing unit test demonstrating the issue: #165

image
@Tarmil Tarmil added the bug Something isn't working label Jul 7, 2023
Tarmil added a commit that referenced this issue Jul 7, 2023
@Tarmil
fix #164: NRE on deserializing missing field with JsonIgnoreCondition…
fca5a58 
….WhenWritingNull
@Tarmil Tarmil mentioned this issue Jul 7, 2023
Merged
Tarmil added a commit that referenced this issue Jul 22, 2023
@Tarmil
Merge pull request #166 from Tarmil/missing-non-null-fields
8b32663 
fix #164: NRE on deserializing missing field with JsonIgnoreCondition.WhenWritingNull
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@Tarmil @mlaily