[fix](metrics) Correct statistical method for file cache stats

TangSiyang2001 · Jan 15, 2025 · 2d905e2 · 2d905e2
1 parent cc183eb
commit 2d905e2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/be/src/io/cache/cached_remote_file_reader.cpp b/be/src/io/cache/cached_remote_file_reader.cpp
@@ -126,8 +126,12 @@ Status CachedRemoteFileReader::read_at_impl(size_t offset, Slice result, size_t*
     ReadStatistics stats;
     auto defer_func = [&](int*) {
         if (io_ctx->file_cache_stats) {
-            _update_state(stats, io_ctx->file_cache_stats, io_ctx->is_inverted_index);
-            io::FileCacheProfile::instance().update(io_ctx->file_cache_stats);
+            // update stats in io_ctx, for query profile
+            _update_stats(stats, io_ctx->file_cache_stats, io_ctx->is_inverted_index);
+            // update stats increment in this reading procedure for file cache metrics
+            FileCacheStatistics fcache_stats_increment;
+            _update_stats(stats, &fcache_stats_increment, io_ctx->is_inverted_index);
+            io::FileCacheProfile::instance().update(&fcache_stats_increment);
         }
     };
     std::unique_ptr<int, decltype(defer_func)> defer((int*)0x01, std::move(defer_func));
@@ -316,7 +320,7 @@ Status CachedRemoteFileReader::read_at_impl(size_t offset, Slice result, size_t*
     return Status::OK();
 }
 
-void CachedRemoteFileReader::_update_state(const ReadStatistics& read_stats,
+void CachedRemoteFileReader::_update_stats(const ReadStatistics& read_stats,
                                            FileCacheStatistics* statis,
                                            bool is_inverted_index) const {
     if (statis == nullptr) {

diff --git a/be/src/io/cache/cached_remote_file_reader.h b/be/src/io/cache/cached_remote_file_reader.h
@@ -67,7 +67,7 @@ class CachedRemoteFileReader final : public FileReader {
     std::shared_mutex _mtx;
     std::map<size_t, FileBlockSPtr> _cache_file_readers;
 
-    void _update_state(const ReadStatistics& stats, FileCacheStatistics* state,
+    void _update_stats(const ReadStatistics& stats, FileCacheStatistics* state,
                        bool is_inverted_index) const;
 };