-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe link in plan #1093
Comments
you can open the entry and click on the recipe on the right side to open it but i think @Kaibu could just add a link to the context menu as well, thats probably a nice feature |
Hello @vabene1111. |
It seems like one of the components is not loading correctly for you, that is very interesting (also i love rote linsen lasange :D) @Kaibu any idea how this can happen ? @schwantuschke can you post how you setup tandoor ? did you use docker or a manual setup and can you see if there are any errors shown in your browser console when visiting the meal plan ? |
Very weird indeed, you should have a Recipe card on the right. Why that is the case - I'll have to investigate |
I'll still add a context menu entry to view the recipe |
this might be related to firefox, we usually test in chrome but there have been several reports over time for stuff not working in firefox. Do you have a chromium based browser to test if it works there ? |
I test now on Chrome (96.0.4664.55), Firefox (94.0.2) and Safari (15.1) on macOS and on Firefox and Safari on iPad OS. Everywhere the same result :( |
Thanks for the extensive testing, very weird issue, we will look into it, sorry for the inconvenience |
Same on https://app.tandoor.dev/plan/ in Firefox and Chrome |
+1 for the original issue (add a link to the recipe, e.g. in the three-dot context menu). Also, I have the same problem as described above (no recipe card visible) on 1.0.4 with Firefox. |
TandoorRecipes#1093 add a recipe link into meal plan
I implemented the context menu entry during lunch break and made a pull request. |
very interesting that this is not working on the hosted instance. I will merge the context menu fix but on my personal instance (which i thought is configured exactly the same way as the hosted instance) this works flawlessly. But this is good, it means i can properly debug it now |
…k_in_plan #1093 Recipe link in plan
@vabene1111 is this still broke? |
The card is still broken but we now have the three dot menu, can be closed. |
I would find it nice if there was a link to the recipe directly in the 3-point menu in the plan.
I can't get to the recipe from the entry, or have I overlooked that?
The text was updated successfully, but these errors were encountered: