fix: replace typeof window checks with typeof document #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
redabacha
commented
Feb 26, 2023
| @@ -103,7 +103,8 @@ export function useWindowVirtualizer<TItemElement extends Element>( | |||
| return useVirtualizerBase<Window, TItemElement>( | |||
| computed(() => ({ | |||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | |||
| getScrollElement: () => (typeof Window !== 'undefined' ? window : null!), | |||
There was a problem hiding this comment.
this would have always evaluated to null since it should have been lowercase window instead of Window 😅
piecyk
approved these changes
Feb 26, 2023
|
Thanks @redabacha |
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the
@tanstack/react-virtualpackage throwsuseLayoutEffect does nothing on the serverwarnings during ssr when using a deno runtime. this is because deno has a global window object available for browser compatibility (though is being considered for removal denoland/deno#13367). also see here for further reading.this pr replaces all
typeof windowchecks across all packages withtypeof documentinstead which works in all environments.prior art: motiondivision/motion#1522