Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting - can't sort titlecase and lowercase #3137

Closed
junagao opened this issue Mar 11, 2021 · 2 comments
Closed

Sorting - can't sort titlecase and lowercase #3137

junagao opened this issue Mar 11, 2021 · 2 comments
Labels

Comments

@junagao
Copy link

junagao commented Mar 11, 2021

Describe the bug (required)
Sorting lowercase and titlecase/uppercase strings not working.

Provide an example via Codesandbox! (required)
https://codesandbox.io/s/ecstatic-fast-umj1u

Steps To Reproduce (required)
Steps to reproduce the behavior:

  1. Click fruit header to sort items

Its sorting first letters starting with Titlecase/Uppercase and then sorts the ones starting with Lowercase.

Expected behavior (Recommended)
Should sort ascending or descending alphabetically correctly.

Screenshots
preview

goldflag added a commit to goldflag/react-table that referenced this issue Apr 25, 2021
New sort types better serve certain edge cases for columns with string or number values. Number strips out non decimal or numerical value from strings and only sorts what is left. String sorts strings case-insensitively until it reaches a title, and then it will do case-sensitive sort (TanStack#3137).
tannerlinsley pushed a commit that referenced this issue Apr 25, 2021
* feat(sortTypes): Add string and number sort types

New sort types better serve certain edge cases for columns with string or number values. Number strips out non decimal or numerical value from strings and only sorts what is left. String sorts strings case-insensitively until it reaches a title, and then it will do case-sensitive sort (#3137).

* docs(useSortBy): Add two new sort types

Add new built-in sort functions 'number' and 'string'

* test(useSortBy): Increase coverage for useSortBy

Add new sort types (number, string) to
certain columns to achieve sufficient coverage.
Cheetah0723 added a commit to Cheetah0723/Table that referenced this issue Nov 7, 2021
* feat(sortTypes): Add string and number sort types

New sort types better serve certain edge cases for columns with string or number values. Number strips out non decimal or numerical value from strings and only sorts what is left. String sorts strings case-insensitively until it reaches a title, and then it will do case-sensitive sort (TanStack/table#3137).

* docs(useSortBy): Add two new sort types

Add new built-in sort functions 'number' and 'string'

* test(useSortBy): Increase coverage for useSortBy

Add new sort types (number, string) to
certain columns to achieve sufficient coverage.
gargroh added a commit to gargroh/react-table that referenced this issue Jan 28, 2022
* fix: provide parentRows and data to accessor

* docs: add link to LineUp-lite (TanStack#3022)

see https://lineup-lite.netlify.app for documentation and details.

* docs: use sponsor iframe

* Update index.js

* docs: ad carbonads

* Update index.css

* Update index.css

* feat: Add two new built in sort types  (TanStack#3235)

* feat(sortTypes): Add string and number sort types

New sort types better serve certain edge cases for columns with string or number values. Number strips out non decimal or numerical value from strings and only sorts what is left. String sorts strings case-insensitively until it reaches a title, and then it will do case-sensitive sort (TanStack#3137).

* docs(useSortBy): Add two new sort types

Add new built-in sort functions 'number' and 'string'

* test(useSortBy): Increase coverage for useSortBy

Add new sort types (number, string) to
certain columns to achieve sufficient coverage.

* docs: fix typo (TanStack#3261)

* Update index.js

* Update index.js

* fixed the typo in CodeSandbox link for material UI (TanStack#3555)

* v7 links

* Update README.md

* Update README.md
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This issue is being marked as stale (no activity in the last 14 days)

@github-actions github-actions bot added the Stale label Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This issue has been detected as stale and automatically closed. It's very likely that your issue has remained here this long because it would require breaking changes to v7. React Table v8 is currently in alpha (soon beta!) and already contains bug fixes, performance improvements and architectural changes that likely address this issue.

  • If your v7 issue has been previously labeled as requiring breaking changes, please try the new v8 alpha/beta releases
  • If your v7 issue has not already been labeled as a breaking change, open a new issue.
  • If this was a v8 issue and was closed by mistake, please reopen or leave a comment below.

@github-actions github-actions bot closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant