-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-router): correctly set pathChanged
in router events
#2649
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d7aaa6a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
needs some tests |
do you think keeping href for some other use-cases would be useful too?
|
@merthanmerter not aware of such use cases, if they arise, we can still add it later. |
fixes #2638