Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): correctly set pathChanged in router events #2649

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

schiller-manuel
Copy link
Contributor

fixes #2638

Copy link

nx-cloud bot commented Oct 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d7aaa6a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 26, 2024

Open in Stackblitz

More templates

@tanstack/create-router

pnpm add https://pkg.pr.new/@tanstack/create-router@2649

@tanstack/eslint-plugin-router

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-router@2649

@tanstack/react-cross-context

pnpm add https://pkg.pr.new/@tanstack/react-cross-context@2649

@tanstack/history

pnpm add https://pkg.pr.new/@tanstack/history@2649

@tanstack/react-router

pnpm add https://pkg.pr.new/@tanstack/react-router@2649

@tanstack/react-router-with-query

pnpm add https://pkg.pr.new/@tanstack/react-router-with-query@2649

@tanstack/router-arktype-adapter

pnpm add https://pkg.pr.new/@tanstack/router-arktype-adapter@2649

@tanstack/router-cli

pnpm add https://pkg.pr.new/@tanstack/router-cli@2649

@tanstack/router-devtools

pnpm add https://pkg.pr.new/@tanstack/router-devtools@2649

@tanstack/router-generator

pnpm add https://pkg.pr.new/@tanstack/router-generator@2649

@tanstack/router-plugin

pnpm add https://pkg.pr.new/@tanstack/router-plugin@2649

@tanstack/router-valibot-adapter

pnpm add https://pkg.pr.new/@tanstack/router-valibot-adapter@2649

@tanstack/router-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/router-vite-plugin@2649

@tanstack/router-zod-adapter

pnpm add https://pkg.pr.new/@tanstack/router-zod-adapter@2649

@tanstack/start

pnpm add https://pkg.pr.new/@tanstack/start@2649

@tanstack/start-vite-plugin

pnpm add https://pkg.pr.new/@tanstack/start-vite-plugin@2649

@tanstack/virtual-file-routes

pnpm add https://pkg.pr.new/@tanstack/virtual-file-routes@2649

commit: d7aaa6a

@schiller-manuel
Copy link
Contributor Author

needs some tests

@merthanmerter
Copy link

needs some tests

do you think keeping href for some other use-cases would be useful too?

const hrefChanged = fromLocation.href!== toLocation.href

@schiller-manuel
Copy link
Contributor Author

@merthanmerter not aware of such use cases, if they arise, we can still add it later.

@schiller-manuel schiller-manuel merged commit 627a0f8 into main Oct 27, 2024
5 checks passed
@schiller-manuel schiller-manuel deleted the fix-pathchanged branch October 27, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants