Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct file extensions to .tsx and add type annotations #8259

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

Ariel-Moroshko
Copy link
Contributor

Summary

This PR corrects file extensions in the React Query Next.js example from .jsx to .tsx and includes minor type annotations to align with TypeScript expectations.

Changes

  • Updated file extensions from .jsx to .tsx to prevent potential issues when using TypeScript in Next.js.
  • Added type annotations (React.ReactNode) for children props in Providers and RootLayout components to improve type safety.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 7, 2024
Copy link

nx-cloud bot commented Nov 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0f76f95. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Ariel-Moroshko Ariel-Moroshko changed the title fix: correct file extensions to .tsx and add type annotations fix(docs): correct file extensions to .tsx and add type annotations Nov 7, 2024
Copy link

pkg-pr-new bot commented Nov 7, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8259

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8259

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8259

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8259

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8259

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8259

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8259

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8259

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8259

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8259

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8259

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8259

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8259

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8259

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8259

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8259

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8259

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8259

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8259

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8259

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8259

commit: 0f76f95

@TkDodo TkDodo merged commit 7085bd1 into TanStack:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants