Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(query-devtools): handle null properties for __previousQueryOptions #8240

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Fix(query-devtools): handle null properties for __previousQueryOptions #8240

merged 2 commits into from
Nov 3, 2024

Conversation

kaehehehe
Copy link
Contributor

@kaehehehe kaehehehe commented Oct 30, 2024 •
edited
Loading

close #7521

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 2, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9dc64e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 2, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8240

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8240

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8240

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8240

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8240

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8240

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8240

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8240

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8240

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8240

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8240

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8240

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8240

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8240

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8240

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8240

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8240

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8240

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8240

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8240

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8240

commit: 9dc64e9

@TkDodo
Copy link
Collaborator

TkDodo commented Nov 2, 2024

Types are erroring, please take a look

@kaehehehe kaehehehe force-pushed the fix/null-query-options-bug branch from 1275c9c to ff4e8a4 Compare November 3, 2024 12:19
@kaehehehe
Copy link
Contributor Author

Fixed!

@kaehehehe kaehehehe requested a review from TkDodo November 3, 2024 12:19
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 4.96%. Comparing base (92defc6) to head (9dc64e9).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           main   #8240      +/-   ##
=======================================
+ Coverage      0   4.96%   +4.96%     
=======================================
  Files         0      17      +17     
  Lines         0    1409    +1409     
  Branches      0     460     +460     
=======================================
+ Hits          0      70      +70     
- Misses        0    1167    +1167     
- Partials      0     172     +172
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools 4.78% <0.00%> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools 10.00% <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 9c93dc0 into TanStack:main Nov 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo Awaiting requested review from TkDodo

Assignees
No one assigned
Labels
package: query-devtools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Cannot read properties of null (reading '__previousQueryOptions')
2 participants
@kaehehehe @TkDodo