Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svelte-5-adapter): require function for createMutation options #7805

Merged
merged 2 commits into from
Jul 27, 2024
Merged

fix(svelte-5-adapter): require function for createMutation options #7805

merged 2 commits into from
Jul 27, 2024

Conversation

lachlancollins
Copy link
Member

Following on from #7804

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 27, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ba3914f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 27, 2024

commit: ba3914f

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7805

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7805

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7805

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7805

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7805

pnpm add https://pkg.pr.new/@tanstack/query-core@7805

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7805

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7805

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7805

pnpm add https://pkg.pr.new/@tanstack/react-query@7805

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7805

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7805

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7805

pnpm add https://pkg.pr.new/@tanstack/solid-query@7805

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7805

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7805

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7805

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7805

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7805

pnpm add https://pkg.pr.new/@tanstack/vue-query@7805

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7805

Open in Stackblitz

More templates

@codecov Codecov
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (svelte-5-adapter@8f190fd). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             svelte-5-adapter    #7805   +/-   ##
===================================================
  Coverage                    ?   43.65%           
===================================================
  Files                       ?      168           
  Lines                       ?     6932           
  Branches                    ?     1543           
===================================================
  Hits                        ?     3026           
  Misses                      ?     3546           
  Partials                    ?      360
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <0.00%> (?)
@tanstack/angular-query-experimental 86.58% <0.00%> (?)
@tanstack/eslint-plugin-query 84.00% <0.00%> (?)
@tanstack/query-async-storage-persister 43.85% <0.00%> (?)
@tanstack/query-broadcast-client-experimental ∅ <0.00%> (?)
@tanstack/query-codemods 0.00% <0.00%> (?)
@tanstack/query-core 92.82% <0.00%> (?)
@tanstack/query-devtools 5.24% <0.00%> (?)
@tanstack/query-persist-client-core 57.73% <0.00%> (?)
@tanstack/query-sync-storage-persister 82.50% <0.00%> (?)
@tanstack/react-query 92.44% <0.00%> (?)
@tanstack/react-query-devtools 10.71% <0.00%> (?)
@tanstack/react-query-next-experimental ∅ <0.00%> (?)
@tanstack/react-query-persist-client 100.00% <0.00%> (?)
@tanstack/solid-query 78.20% <0.00%> (?)
@tanstack/solid-query-devtools ∅ <0.00%> (?)
@tanstack/solid-query-persist-client 100.00% <0.00%> (?)
@tanstack/svelte-query ∅ <0.00%> (?)
@tanstack/svelte-query-devtools ∅ <0.00%> (?)
@tanstack/svelte-query-persist-client 100.00% <0.00%> (?)
@tanstack/vue-query 71.42% <0.00%> (?)
@tanstack/vue-query-devtools ∅ <0.00%> (?)

@lachlancollins lachlancollins merged commit 80a675e into svelte-5-adapter Jul 27, 2024
8 checks passed
@lachlancollins lachlancollins deleted the create-mutation-options branch July 27, 2024 05:36
lachlancollins added a commit that referenced this pull request Jul 28, 2024
@lachlancollins
fix(svelte-5-adapter): function for createMutation options (#7805)
33e2054 
* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
lachlancollins added a commit that referenced this pull request Jul 29, 2024
@lachlancollins
fix(svelte-5-adapter): function for createMutation options (#7805)
f8c2878 
* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
lachlancollins added a commit that referenced this pull request Jul 31, 2024
@lachlancollins
fix(svelte-5-adapter): function for createMutation options (#7805)
233666d 
* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
lachlancollins pushed a commit that referenced this pull request Aug 2, 2024
@zhihengGet @lachlancollins
WIP: Svelte 5 adapter (#6981)
0cd7069 
docs(svelte-5-adapter): force runes mode for all examples (#7800)

* docs(examples): force runes mode for all examples

* Fix simple example mounting

* Fix type
feat(svelte-5-adapter): require options to be passed as function (#7804)

* fix(svelte-5-adapter): Require options to be passed as function

* More fixes

* More fixes

* Update examples

fix(svelte-5-adapter): function for `createMutation` options (#7805)

* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
refactor(svelte-5-adapter): simplify createBaseQuery (#7808)

* refactor: simplify createBaseQuery

* Don't take snapshot of queryKey
chore(svelte-5-adapter): tidy-up functions (#7809)

* chore(svelte-5-adapter): tidy-up functions

* Fix types

* Update svelte

Fix import extensions

chore: ignore state_snapshot_uncloneable in tests
lachlancollins pushed a commit that referenced this pull request Aug 9, 2024
@zhihengGet @lachlancollins
WIP: Svelte 5 adapter (#6981)
9a65104 
docs(svelte-5-adapter): force runes mode for all examples (#7800)

* docs(examples): force runes mode for all examples

* Fix simple example mounting

* Fix type
feat(svelte-5-adapter): require options to be passed as function (#7804)

* fix(svelte-5-adapter): Require options to be passed as function

* More fixes

* More fixes

* Update examples

fix(svelte-5-adapter): function for `createMutation` options (#7805)

* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
refactor(svelte-5-adapter): simplify createBaseQuery (#7808)

* refactor: simplify createBaseQuery

* Don't take snapshot of queryKey
chore(svelte-5-adapter): tidy-up functions (#7809)

* chore(svelte-5-adapter): tidy-up functions

* Fix types

* Update svelte

Fix import extensions

chore: ignore state_snapshot_uncloneable in tests
lachlancollins pushed a commit that referenced this pull request Aug 30, 2024
@zhihengGet @lachlancollins
WIP: Svelte 5 adapter (#6981)
5cd8528 
docs(svelte-5-adapter): force runes mode for all examples (#7800)

* docs(examples): force runes mode for all examples

* Fix simple example mounting

* Fix type
feat(svelte-5-adapter): require options to be passed as function (#7804)

* fix(svelte-5-adapter): Require options to be passed as function

* More fixes

* More fixes

* Update examples

fix(svelte-5-adapter): function for `createMutation` options (#7805)

* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
refactor(svelte-5-adapter): simplify createBaseQuery (#7808)

* refactor: simplify createBaseQuery

* Don't take snapshot of queryKey
chore(svelte-5-adapter): tidy-up functions (#7809)

* chore(svelte-5-adapter): tidy-up functions

* Fix types

* Update svelte

Fix import extensions

chore: ignore state_snapshot_uncloneable in tests


Fix merge
lachlancollins pushed a commit that referenced this pull request Aug 30, 2024
@zhihengGet @lachlancollins
WIP: Svelte 5 adapter (#6981)
367c06b 
docs(svelte-5-adapter): force runes mode for all examples (#7800)

* docs(examples): force runes mode for all examples

* Fix simple example mounting

* Fix type
feat(svelte-5-adapter): require options to be passed as function (#7804)

* fix(svelte-5-adapter): Require options to be passed as function

* More fixes

* More fixes

* Update examples

fix(svelte-5-adapter): function for `createMutation` options (#7805)

* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
refactor(svelte-5-adapter): simplify createBaseQuery (#7808)

* refactor: simplify createBaseQuery

* Don't take snapshot of queryKey
chore(svelte-5-adapter): tidy-up functions (#7809)

* chore(svelte-5-adapter): tidy-up functions

* Fix types

* Update svelte

Fix import extensions

chore: ignore state_snapshot_uncloneable in tests


Fix merge
lachlancollins pushed a commit that referenced this pull request Sep 25, 2024
@zhihengGet @lachlancollins
WIP: Svelte 5 adapter (#6981)
ccce0b8 
docs(svelte-5-adapter): force runes mode for all examples (#7800)

* docs(examples): force runes mode for all examples

* Fix simple example mounting

* Fix type
feat(svelte-5-adapter): require options to be passed as function (#7804)

* fix(svelte-5-adapter): Require options to be passed as function

* More fixes

* More fixes

* Update examples

fix(svelte-5-adapter): function for `createMutation` options (#7805)

* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
refactor(svelte-5-adapter): simplify createBaseQuery (#7808)

* refactor: simplify createBaseQuery

* Don't take snapshot of queryKey
chore(svelte-5-adapter): tidy-up functions (#7809)

* chore(svelte-5-adapter): tidy-up functions

* Fix types

* Update svelte

Fix import extensions

chore: ignore state_snapshot_uncloneable in tests


Fix merge
lachlancollins pushed a commit that referenced this pull request Nov 4, 2024
@zhihengGet @lachlancollins
WIP: Svelte 5 adapter (#6981)
28f98f9 
docs(svelte-5-adapter): force runes mode for all examples (#7800)

* docs(examples): force runes mode for all examples

* Fix simple example mounting

* Fix type
feat(svelte-5-adapter): require options to be passed as function (#7804)

* fix(svelte-5-adapter): Require options to be passed as function

* More fixes

* More fixes

* Update examples

fix(svelte-5-adapter): function for `createMutation` options (#7805)

* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
refactor(svelte-5-adapter): simplify createBaseQuery (#7808)

* refactor: simplify createBaseQuery

* Don't take snapshot of queryKey
chore(svelte-5-adapter): tidy-up functions (#7809)

* chore(svelte-5-adapter): tidy-up functions

* Fix types

* Update svelte

Fix import extensions

chore: ignore state_snapshot_uncloneable in tests


Fix merge
lachlancollins pushed a commit that referenced this pull request Dec 14, 2024
@zhihengGet @lachlancollins
WIP: Svelte 5 adapter (#6981)
56f67c7 
docs(svelte-5-adapter): force runes mode for all examples (#7800)

* docs(examples): force runes mode for all examples

* Fix simple example mounting

* Fix type
feat(svelte-5-adapter): require options to be passed as function (#7804)

* fix(svelte-5-adapter): Require options to be passed as function

* More fixes

* More fixes

* Update examples

fix(svelte-5-adapter): function for `createMutation` options (#7805)

* fix(svelte-5-adapter): require function for createMutation options

* Fix type errors
refactor(svelte-5-adapter): simplify createBaseQuery (#7808)

* refactor: simplify createBaseQuery

* Don't take snapshot of queryKey
chore(svelte-5-adapter): tidy-up functions (#7809)

* chore(svelte-5-adapter): tidy-up functions

* Fix types

* Update svelte

Fix import extensions

chore: ignore state_snapshot_uncloneable in tests


Fix merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: svelte-query package: svelte-query-persist-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lachlancollins