-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(utils): Ensure consistent declaration style of utility functions and standardize parameters for the sleep method #7554
Conversation
…dated this one to match.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 87306cb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 87306cb:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7554 +/- ##
===========================================
+ Coverage 43.87% 62.25% +18.38%
===========================================
Files 184 124 -60
Lines 7027 4478 -2549
Branches 1534 1233 -301
===========================================
- Hits 3083 2788 -295
+ Misses 3578 1459 -2119
+ Partials 366 231 -135 |
I noticed that most functions within the
packages/*/src/utils.ts
andpackages/*/src/__tests__/utils.ts
files were declared as regular functions, so I made consistent adjustments.While most were already in this format, I found a few arrow functions and updated them accordingly (It doesn't seem to be using the 'this").
Additionally, I noticed inconsistency in the parameters of the sleep function, where some used timeout while others used ms, so I unified them all to ms.