refactor(rect-query): prefer client-only import over 'use client' #5626
Conversation
for things that cannot work on the server, like the QueryClientProvider or the hooks; this will give better error message when attempted to be used in a server component
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@Ephem this is a follow-up to: |
☁️ Nx Cloud ReportCI is running for commit f27633d. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f27633d:
|
There was a problem hiding this comment.
Looks good to me!
I noticed the build was failing, I'm guessing the failing test is just a flaky one since it's a vue-test?
Also noticed it complained about the package rollup-plugin-preserve-directives was missing, do you know why? Seemed to happen after the bump right?
|
I had to bump the package to fix the build error |
|
Oh, there was that |
|
the only remaining failure is the flaky vue test |
for things that cannot work on the server, like the QueryClientProvider or the hooks; this will give better error message when attempted to be used in a server component