-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-5538]: Assign observer's current Result when optimistic read occurs #5573
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
f1187b9
to
125a52a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much 🙌
packages/react-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2ef9021. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
… v5 easier & remove fake timers
0d68f6d
to
3702e9b
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ef9021:
|
Here a codesandbox forked from the issue using the version from this PR, I think it solves it https://codesandbox.io/s/serene-keller-h34qgm?file=/src/App.js |
I think we can ship this, but could you please also make the same PR to the |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #5573 +/- ##
==========================================
- Coverage 92.19% 91.50% -0.70%
==========================================
Files 112 101 -11
Lines 4294 3921 -373
Branches 1127 989 -138
==========================================
- Hits 3959 3588 -371
+ Misses 314 308 -6
- Partials 21 25 +4
☔ View full report in Codecov by Sentry. |
Yes sure, I ported the changes to alpha branch in this PR. |
…or placeholderData
there is one test failing now @incepter:
|
fixes #5538