Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subpackage dependencies #4013

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: subpackage dependencies #4013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/query-async-storage-persister/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@
"scripts": {
"clean": "rm -rf ./build",
"test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src"
},
"dependencies": {
"@tanstack/react-query-persist-client": "^4.0.10"
}
}
1 change: 1 addition & 0 deletions packages/query-broadcast-client-experimental/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src"
},
"dependencies": {
"@tanstack/query-core": "^4.0.10",
"broadcast-channel": "^3.4.1"
}
}
3 changes: 3 additions & 0 deletions packages/query-sync-storage-persister/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@
"scripts": {
"clean": "rm -rf ./build",
"test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src"
},
"dependencies": {
"@tanstack/react-query-persist-client": "^4.0.10"
Comment on lines +34 to +35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's wrong that query-* packages depend on react-query-* packages! It seems that we only import some types, so maybe it should just be the other way around and we should in fact move the types ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good point. However the types that are imported are common for both persisters. I would say that we should extract common logic from react-query-persist-client to query-persist-client so framework-specific adapters would be possible.
But that could be next step.

}
}
11 changes: 6 additions & 5 deletions packages/react-query-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
".": {
"development": {
"types": "./build/lib/index.d.ts",
"require": "./build/lib/index.js",
"default": "./build/lib/index.mjs"
"import": "./build/lib/index.mjs",
"default": "./build/lib/index.js"
},
"default": {
"types": "./build/lib/index.d.ts",
"require": "./build/lib/noop.js",
"default": "./build/lib/noop.mjs"
"import": "./build/lib/noop.mjs",
"default": "./build/lib/noop.js"
}
},
"./production": {
Expand All @@ -44,7 +44,8 @@
"test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src"
},
"dependencies": {
"@tanstack/match-sorter-utils": "^8.0.0-alpha.82",
"@tanstack/match-sorter-utils": "^8.1.1",
"@tanstack/react-query": "^4.0.10",
"@types/use-sync-external-store": "^0.0.3",
"use-sync-external-store": "^1.2.0"
}
Expand Down
4 changes: 4 additions & 0 deletions packages/react-query-persist-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,9 @@
"scripts": {
"clean": "rm -rf ./build",
"test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src"
},
"dependencies": {
"@tanstack/query-core": "^4.0.10",
"@tanstack/react-query": "^4.0.10"
}
}
2 changes: 1 addition & 1 deletion packages/react-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"react-error-boundary": "^3.1.4"
},
"dependencies": {
"@tanstack/query-core": "^4.0.0-beta.1",
"@tanstack/query-core": "^4.0.10",
"@types/use-sync-external-store": "^0.0.3",
"use-sync-external-store": "^1.2.0"
},
Expand Down
1 change: 1 addition & 0 deletions rollup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ export default function rollup(options: RollupOptions): RollupOptions[] {
entryFile: 'src/index.ts',
globals: {
react: 'React',
'@tanstack/query-core': 'QueryCore',
'@tanstack/react-query': 'ReactQuery',
},
}),
Expand Down