Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type:module property to package.json #3977

Conversation

ArtyCodingart
Copy link

@ArtyCodingart ArtyCodingart commented Aug 3, 2022

If the "--experimental-vm-modules" property is set, modules are processed with an error.

image

Adding the property type: "module" solves this problem.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6bd8159:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration

@DamianOsipiuk
Copy link
Contributor

DamianOsipiuk commented Aug 9, 2022

I do not think that adding type: module is a good idea.
I think we should rather switch exports statements so default points to cjs and import points to esm.

Also this PR #3892 should add proper .mjs extension which should fix this particular problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants