Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): stop devtools explorer from un-expanding when data is fetched #3687

Closed

Conversation

markmurphydev
Copy link

Fixes #3681

Reverts the change in #2949 from function handleEntry to component HandleEntry, but keeps the added types.
I'm not actually sure why that fixes the un-expanding, but it does.

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 9, 2022

thank you. there are still type errors, please have a look:

Error: src/devtools/tests/Explorer.test.tsx(42,11): error TS2322: Type '{ label: string; toggleExpanded: Mock<any, any>; pageSize: number; expanded: false; subEntryPages: { label: string; }[][]; HandleEntry: () => Element; value: undefined; subEntries: never[]; type: string; }' is not assignable to type 'IntrinsicAttributes & RendererProps'.
Property 'HandleEntry' does not exist on type 'IntrinsicAttributes & RendererProps'. Did you mean 'handleEntry'?

@markmurphydev
Copy link
Author

When running yarn test:ci, prettier fails on file types/index.d.ts
This also happens when I check out origin/master on a new gitpod workspace, and try to run the tests.
When I removed the semicolons in types/index.d.ts, the workflow tests seemed to pass fine, but the type files aren't tracked by git.

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 9, 2022

prettier runs before the types are generated, so that's fine :)

@markmurphydev
Copy link
Author

Great! In that case, the type errors are fixed, and data explorer is staying expanded.

@TkDodo
Copy link
Collaborator

TkDodo commented Jul 17, 2022

can you do me a favour and rebase this to the beta branch? Release is imminent and I'd want to avoid merge conflicts because we moved lots of things around. thanks

@TkDodo
Copy link
Collaborator

TkDodo commented Aug 13, 2022

@boathouse2112 sorry that I missed this somehow. Can you please fix the conflicts? Then this should be good to merge 🚀

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 23, 2022

FYI, I will close stale PRs somewhen next week. Please either address the open comments / resolve the merge conflicts or this PR will be closed. Thanks 🙏

If someone else wants to take over this PR, please do

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 24, 2022

@TkDodo TkDodo closed this Sep 24, 2022
@TkDodo
Copy link
Collaborator

TkDodo commented Sep 24, 2022

@boathouse2112 I'll still attribute you as contributor alongside @zorzysty to the upcoming release. Thanks for your contribution 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data tree won't stay expanded in Data Explorer in devtools
2 participants