Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useSyncExternalStore re-export #3656

Merged
merged 2 commits into from
May 29, 2022
Merged

fix: useSyncExternalStore re-export #3656

merged 2 commits into from
May 29, 2022

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented May 29, 2022

fixes #3637

@TkDodo
fix: useSyncExternalStore re-export
9a6c833 
This is due to esm/cjs interop
@vercel
Copy link

vercel bot commented May 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-query ✅ Ready (Inspect) Visit Preview May 29, 2022 at 7:03PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 29, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07daeed:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented May 29, 2022 •
edited
Loading

Codecov Report

Merging #3656 (07daeed) into beta (068b974) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             beta    #3656   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          49       50    +1     
  Lines        2392     2393    +1     
  Branches      708      708           
=======================================
+ Hits         2323     2324    +1     
  Misses         67       67           
  Partials        2        2
Impacted Files Coverage Δ
src/reactjs/useSyncExternalStore.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068b974...07daeed. Read the comment docs.

@TkDodo
fix: useSyncExternalStore re-export
07daeed 
also fix react native re-export
sachinraja
sachinraja approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@sachinraja sachinraja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend testing this to make sure it fixes the error, but changes look good to me

@TkDodo
Copy link
Collaborator Author

TkDodo commented May 29, 2022

thx. I tested it manually on the example repo from the issue by using the codesandbox preview build, and it worked. not sure how to automate it though.

@TkDodo TkDodo merged commit 2a02eb6 into TanStack:beta May 29, 2022
@TkDodo TkDodo deleted the feature/uSES-re-export branch May 29, 2022 19:07
@sachinraja
Copy link
Contributor

For now it would help to upgrade code sandbox to the latest version of CRA.

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinraja sachinraja sachinraja approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TkDodo @sachinraja @tannerlinsley