Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure isDataEqual option is respected everywhere where we use structuralSharing #3643

Merged
merged 1 commit into from
May 25, 2022

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented May 25, 2022

No description provided.

@vercel
Copy link

vercel bot commented May 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-query ✅ Ready (Inspect) Visit Preview May 25, 2022 at 4:03PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17f20d4:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #3643 (17f20d4) into beta (40b921a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             beta    #3643   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          49       49           
  Lines        2388     2388           
  Branches      709      707    -2     
=======================================
  Hits         2319     2319           
  Misses         67       67           
  Partials        2        2           
Impacted Files Coverage Δ
src/core/query.ts 100.00% <100.00%> (ø)
src/core/queryObserver.ts 100.00% <100.00%> (ø)
src/core/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b921a...17f20d4. Read the comment docs.

@TkDodo TkDodo merged commit 270efe6 into TanStack:beta May 25, 2022
@TkDodo TkDodo deleted the feature/respect-isDataEqual-everywhere branch May 25, 2022 16:04
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants