fix: move usage of React Context out of core package #3578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can import them in core
because they render a component
so that we can't import anything into `core` that lives in other packages, like reactjs
by keeping HydrateOptions separate from React, and only add ContextOptions where necessary
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@DamianOsipiuk fyi |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 690a187:
|
Codecov Report
@@ Coverage Diff @@
## beta #3578 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 47 48 +1
Lines 2381 2382 +1
Branches 709 709
=======================================
+ Hits 2308 2309 +1
Misses 71 71
Partials 2 2
Continue to review full report at Codecov.
|
DamianOsipiuk
approved these changes
May 6, 2022
|
🎉 This PR is included in version 4.0.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3542