Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing errorUpdateCount on useQuery #3532

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Exposing errorUpdateCount on useQuery #3532

merged 8 commits into from
Apr 22, 2022

Conversation

OmerCohenAviv
Copy link
Contributor

exposing errorUpdateCount state,

@vercel
Copy link

vercel bot commented Apr 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-query ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 10:59PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 19, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b27d33:

Sandbox Source
tannerlinsley/react-query Configuration
tannerlinsley/react-query Configuration

TkDodo
TkDodo reviewed Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good already 🙌

docs/src/pages/reference/useQuery.md Outdated Show resolved Hide resolved
src/core/queryObserver.ts Show resolved Hide resolved
src/react/tests/useQuery.test.tsx Outdated Show resolved Hide resolved
@OmerCohenAviv @TkDodo
Update docs/src/pages/reference/useQuery.md
9608825 
as  suggested

Co-authored-by: Dominik Dorfmeister <[email protected]>
@OmerCohenAviv OmerCohenAviv requested a review from TkDodo April 20, 2022 15:23
@TkDodo
Copy link
Collaborator

TkDodo commented Apr 21, 2022

please check prettier:

> [email protected] test:format
> yarn prettier --check

$ prettier "{.,src,src/**,example/src,example/src/**,types}/*.{md,js,jsx,ts,tsx,json}" --check
Checking formatting...
[warn] src/react/tests/useQuery.test.tsx
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 21, 2022

some test are failing - please add errorUpdateCount to the failing tests

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 21, 2022

now there are conflicts, sorry 🙈 . can you please resolve them?

@OmerCohenAviv
Copy link
Contributor Author

now there are conflicts, sorry 🙈 . can you please resolve them?

hopefully it's ok now sorry for trouble

@codecov
Copy link

codecov bot commented Apr 22, 2022 •
edited
Loading

Codecov Report

Merging #3532 (6b27d33) into master (fab76e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3532   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          45       45           
  Lines        2277     2277           
  Branches      637      637           
=======================================
  Hits         2194     2194           
  Misses         80       80           
  Partials        3        3
Impacted Files Coverage Δ
src/core/queryObserver.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab76e6...6b27d33. Read the comment docs.

@TkDodo TkDodo merged commit 558878c into TanStack:master Apr 22, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

OmerCohenAviv added a commit to OmerCohenAviv/react-query that referenced this pull request Apr 22, 2022
@OmerCohenAviv
Revert "feat: expose errorUpdateCount on useQuery (TanStack#3532)"
bd4f8de 
This reverts commit 558878c.
MMMikeM pushed a commit to MMMikeM/react-query that referenced this pull request May 23, 2022
@OmerCohenAviv @TkDodo @MMMikeM
feat: expose errorUpdateCount on useQuery (TanStack#3532)
a804fcc 
* expose errorUpdateCount on useQuery

* refactored test slightly

* Update docs/src/pages/reference/useQuery.md

as  suggested

Co-authored-by: Dominik Dorfmeister <[email protected]>

* removed the first click as we fetch on default,

* prettier

* added errorUpdateCount to failed tests.

* prettier

Co-authored-by: Dominik Dorfmeister <[email protected]>
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmerCohenAviv @TkDodo @tannerlinsley