Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persistQueryClient): rename isHydrating to isRestoring #3512

Merged
merged 9 commits into from
Apr 21, 2022

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Apr 15, 2022

No description provided.

TkDodo added 4 commits April 15, 2022 08:40
hydration moved to the core, and the build entry point was already removed for v4. this is just a proper cleanup.
as we currently have no plans to re-use this for useHydrate, it would be confusing to not get true for this value in those cases
@vercel
Copy link

vercel bot commented Apr 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/14oh1knjd7jGuYaywuQxBQsZmCHA
✅ Preview: https://react-query-git-fork-tkdodo-feature-rename-usei-4f4ac1-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 15, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d0b4a1:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #3512 (7d0b4a1) into beta (a8ddd9b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             beta    #3512   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          46       47    +1     
  Lines        2381     2381           
  Branches      709      709           
=======================================
  Hits         2308     2308           
  Misses         71       71           
  Partials        2        2           
Impacted Files Coverage Δ
src/core/query.ts 100.00% <ø> (ø)
src/devtools/devtools.tsx 87.00% <ø> (ø)
src/devtools/utils.ts 95.83% <ø> (ø)
src/reactjs/Hydrate.tsx 100.00% <ø> (ø)
src/core/queryObserver.ts 100.00% <100.00%> (ø)
.../persistQueryClient/PersistQueryClientProvider.tsx 100.00% <100.00%> (ø)
src/reactjs/QueryErrorResetBoundary.tsx 100.00% <100.00%> (ø)
src/reactjs/isRestoring.tsx 100.00% <100.00%> (ø)
src/reactjs/useBaseQuery.ts 100.00% <100.00%> (ø)
src/reactjs/useQueries.ts 95.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ddd9b...7d0b4a1. Read the comment docs.

@TkDodo TkDodo requested a review from Ephem April 15, 2022 11:54
we want a constant value for the lifetime of the QueryErrorResetBoundary component; useMemo doesn't guarantee that.
@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-query ✅ Ready (Inspect) Visit Preview Apr 21, 2022 at 6:26PM (UTC)

we don't have a queryKey at this point if a string was used due to how the overloads try to spread things
@TkDodo TkDodo merged commit 9e23e7a into TanStack:beta Apr 21, 2022
@TkDodo TkDodo deleted the feature/rename-useIsHydrating branch April 21, 2022 18:28
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants