-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(persistQueryClient): rename isHydrating to isRestoring #3512
Conversation
hydration moved to the core, and the build entry point was already removed for v4. this is just a proper cleanup.
as we currently have no plans to re-use this for useHydrate, it would be confusing to not get true for this value in those cases
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/14oh1knjd7jGuYaywuQxBQsZmCHA |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d0b4a1:
|
Codecov Report
@@ Coverage Diff @@
## beta #3512 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 46 47 +1
Lines 2381 2381
Branches 709 709
=======================================
Hits 2308 2308
Misses 71 71
Partials 2 2
Continue to review full report at Codecov.
|
we want a constant value for the lifetime of the QueryErrorResetBoundary component; useMemo doesn't guarantee that.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
as discussed here: TanStack#2688 (comment)
we don't have a queryKey at this point if a string was used due to how the overloads try to spread things
🎉 This PR is included in version 4.0.0-beta.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.