Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): QueryKey height #3497

Merged
merged 3 commits into from
Apr 15, 2022
Merged

fix(devtools): QueryKey height #3497

merged 3 commits into from
Apr 15, 2022

Conversation

always-maap
Copy link
Contributor

fixes this

2022-04-12-122944_1920x1080_scrot

@vercel
Copy link

vercel bot commented Apr 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/55wMYJNW9XXaruuLmHgdDTnAh9G6
✅ Preview: https://react-query-git-fork-always-maap-master-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a7a5bc:

Sandbox Source
tannerlinsley/react-query Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 12, 2022

fixes this

what exactly is the issue in the screenshot please? Somehow, I don't see it 🙈

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #3497 (5a7a5bc) into master (70e3d47) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3497   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          45       45           
  Lines        2286     2286           
  Branches      642      642           
=======================================
  Hits         2204     2204           
  Misses         79       79           
  Partials        3        3           
Impacted Files Coverage Δ
src/devtools/devtools.tsx 79.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4ef9b...5a7a5bc. Read the comment docs.

@always-maap
Copy link
Contributor Author

always-maap commented Apr 12, 2022

oh my bad. it fixes the height of the query state. I thought this is not right. if it is by design feel free to close <3

2022-04-12-142351_1920x1080_scrot

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 15, 2022

thanks, I don't think its per design. However, in the preview build (https://codesandbox.io/s/tannerlinsley-react-query-basic-forked-ko2pop?file=/src/index.js), I can still see the issue being present.

Screenshot 2022-04-15 at 19 47 23

the container uses align-items: stretch, and if we'd change that to flex-start, the issue would go away for me...

https://github.com/tannerlinsley/react-query/blob/c1ae82ba188fd5abda5e256cac070145e5941447/src/devtools/devtools.tsx#L710

@vercel
Copy link

vercel bot commented Apr 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-query ✅ Ready (Inspect) Visit Preview Apr 15, 2022 at 6:59PM (UTC)

@always-maap
Copy link
Contributor Author

I revert the height and fix the container alignItems. please squash and merge if you consider merging this. if it's unnecessary feel free to close it <3

@TkDodo TkDodo merged commit 1ab13dc into TanStack:master Apr 15, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants