-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: React implicit children type #3490
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/HjfhdQ8ju7pDhennjkJcZZ75pZ3z |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 31bcc46:
|
Closed since this is already being fixed here - #3482 |
My mistake. Reinstall the package the types got updated! |
Usage of React.FC was removed in an earlier PR for v4, so there was no change necessary |
With this recent change in
@types/react
- DefinitelyTyped/DefinitelyTyped#56210 the type check fails forQueryClientProvider
and other components which havechildren
as a prop.This is a particular failure when using
^@types/react@18
. Adding thechildren
type explicitly to these components.