Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix suspense example #3458

Merged
merged 5 commits into from
Apr 2, 2022
Merged

docs: fix suspense example #3458

merged 5 commits into from
Apr 2, 2022

Conversation

nikasepiskveradze
Copy link
Contributor

This is the possible fix for #3453

@vercel
Copy link

vercel bot commented Mar 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/GErnKujwcbP5oWzr4THWTQRc2FLR
✅ Preview: https://react-query-git-fork-nikasepiskveradze-suspense-286b22-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de9ba43:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query Configuration

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #3458 (de9ba43) into master (ba09e16) will increase coverage by 0.53%.
The diff coverage is 97.77%.

@@            Coverage Diff             @@
##           master    #3458      +/-   ##
==========================================
+ Coverage   96.41%   96.94%   +0.53%     
==========================================
  Files          45       46       +1     
  Lines        2286     2391     +105     
  Branches      642      714      +72     
==========================================
+ Hits         2204     2318     +114     
+ Misses         79       71       -8     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/devtools/theme.tsx 100.00% <ø> (ø)
src/reactjs/QueryErrorResetBoundary.tsx 100.00% <ø> (ø)
src/reactjs/reactBatchedUpdates.ts 100.00% <ø> (ø)
src/reactjs/setBatchUpdatesFn.ts 100.00% <ø> (ø)
src/reactjs/tests/utils.tsx 97.72% <ø> (ø)
src/reactjs/useBaseQuery.ts 100.00% <ø> (ø)
src/reactjs/useInfiniteQuery.ts 100.00% <ø> (ø)
src/reactjs/useIsFetching.ts 87.50% <ø> (ø)
src/reactjs/useIsMutating.ts 87.50% <ø> (ø)
src/reactjs/useMutation.ts 94.73% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba09e16...de9ba43. Read the comment docs.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't the peerDependency installation fail, because react-query v3 still requires a peerDependency of react 16 || 17 ?

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 1, 2022

i tried it out and it seems to work. however, the interface of useTransition seems to have changed.

We do:

const [startTransition, isPending] = React.useTransition({

it should be:

const [isPending, startTransition] = React.useTransition({

@nikasepiskveradze
Copy link
Contributor Author

wouldn't the peerDependency installation fail, because react-query v3 still requires a peerDependency of react 16 || 17 ?

Agree, I don't have other solution so we can close this merge request

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 1, 2022

we can rebase this pr to alpha once I have merged:

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 2, 2022

beta is released with react 18 support. can you rebase this PR onto the beta branch please, then we can go ahead with merging :)

@nikasepiskveradze
Copy link
Contributor Author

beta is released with react 18 support. can you rebase this PR onto the beta branch please, then we can go ahead with merging :)

I'm not sure if i did it correctly, If something is wrong I will create new branch from "beta" and send PR of those changes

@nikasepiskveradze nikasepiskveradze changed the base branch from master to beta April 2, 2022 17:30
@TkDodo TkDodo merged commit 231b543 into TanStack:beta Apr 2, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants