-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix suspense example #3458
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/GErnKujwcbP5oWzr4THWTQRc2FLR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de9ba43:
|
Codecov Report
@@ Coverage Diff @@
## master #3458 +/- ##
==========================================
+ Coverage 96.41% 96.94% +0.53%
==========================================
Files 45 46 +1
Lines 2286 2391 +105
Branches 642 714 +72
==========================================
+ Hits 2204 2318 +114
+ Misses 79 71 -8
+ Partials 3 2 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't the peerDependency installation fail, because react-query v3 still requires a peerDependency of react 16 || 17 ?
i tried it out and it seems to work. however, the interface of We do:
it should be:
|
Agree, I don't have other solution so we can close this merge request |
we can rebase this pr to |
beta is released with react 18 support. can you rebase this PR onto the |
I'm not sure if i did it correctly, If something is wrong I will create new branch from "beta" and send PR of those changes |
🎉 This PR is included in version 4.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is the possible fix for #3453