-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): Add react/jsx-key lint rule #3447
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/AXiSa2qJAQuPsww1HN6hsmouGQEL |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8fba1f0:
|
This pr is expected to fail based on the new rule until #3447 is merged where rule violations are fixed |
please update with master to make the new rule pass |
Rule is set to error. option checkFragmentShorthand option set to true, meaning the rule is used for shorthand fragment syntax too. option will default to true next major eslint-plugin-react version See rule docs [here](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-key.md)
Codecov Report
@@ Coverage Diff @@
## master #3447 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 45 45
Lines 2286 2286
Branches 642 642
=======================================
Hits 2204 2204
Misses 79 79
Partials 3 3 Continue to review full report at Codecov.
|
@TkDodo rebased |
🎉 This PR is included in version 4.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.34.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Rule is set to error.
option checkFragmentShorthand option set to true, meaning the rule is used for shorthand fragment syntax too.
option will default to true next major eslint-plugin-react version
See rule docs here