Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): Add react/jsx-key lint rule #3447

Merged
merged 1 commit into from
Mar 28, 2022
Merged

chore(eslint): Add react/jsx-key lint rule #3447

merged 1 commit into from
Mar 28, 2022

Conversation

Liam-Tait
Copy link
Contributor

Rule is set to error.
option checkFragmentShorthand option set to true, meaning the rule is used for shorthand fragment syntax too.
option will default to true next major eslint-plugin-react version

See rule docs here

@vercel
Copy link

vercel bot commented Mar 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/AXiSa2qJAQuPsww1HN6hsmouGQEL
✅ Preview: https://react-query-git-fork-liam-tait-add-react-jsx-ke-e6891b-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8fba1f0:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query Configuration

@Liam-Tait
Copy link
Contributor Author

This pr is expected to fail based on the new rule until #3447 is merged where rule violations are fixed

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 27, 2022

please update with master to make the new rule pass

Rule is set to error.
option checkFragmentShorthand option set to true,  meaning the rule is used for shorthand fragment syntax too.
option will default to true next major eslint-plugin-react version

See rule docs [here](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-key.md)
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #3447 (8fba1f0) into master (9f23b64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3447   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          45       45           
  Lines        2286     2286           
  Branches      642      642           
=======================================
  Hits         2204     2204           
  Misses         79       79           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f23b64...8fba1f0. Read the comment docs.

@Liam-Tait
Copy link
Contributor Author

@TkDodo rebased

@TkDodo TkDodo merged commit ba09e16 into TanStack:master Mar 28, 2022
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants