fix(useIsFetching): account for fetches happening in the same render cycle #3438
Conversation
…cycle if a fetch happens in the same render cycle as useIsFetching is mounting, but it is mounted after the query, what happens is that: - the initial state of `isFetching` is `0` because the effect to fetch the query hasn't started yet - the query effect runs before the isFetching effect, which means we miss the event, thus the next event we get from the subscription gives us 0 again so we need to check for isFetching in the effect that runs to set up the subscription as well. This catches fetches that basically started in the same effect cycle, but before "our" effect ran
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/CuSyeik8Wo4TJcrkBRnoixhoSkdi |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 86df754:
|
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 45 45
Lines 2278 2282 +4
Branches 641 641
=======================================
+ Hits 2196 2200 +4
Misses 79 79
Partials 3 3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.34.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0-alpha.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #3437
if a fetch happens in the same render cycle as useIsFetching is mounting, but it is mounted after the query, what happens is that:
isFetchingis0because the effect to fetch the query hasn't started yetso we need to check for isFetching in the effect that runs to set up the subscription as well. This catches fetches that basically started in the same effect cycle, but before "our" effect ran