fix(mem): Stop leak from cacheTime outliving Query given WeakRef support (v3) #3367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue described in SSR: High memory consumption on server in environments with
WeakRef
support (most importantly Node 14.6+). I believe this will allow entireQueryClient
instances to be garbage collected promptly now, even withcacheTime
s much longer than the lifetime of theQueryClient
instance.I've included a couple of skipped tests that require being run with
--expose-gc
to reproduce the problem and confirm the fix, I didn't want to mess with y'all test setup but there they are.Cheers
Io