-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codemod: ERR_REQUIRE_ESM when migrating from v4 to v5 #7154
Labels
help wanted
Extra attention is needed
Comments
this is the same as : if you know how to fix it, please contribute. |
TkDodo
changed the title
ERR_REQUIRE_ESM when migrating from v4 to v5 with codegen
codemod: ERR_REQUIRE_ESM when migrating from v4 to v5
Mar 22, 2024
ontanj
added a commit
to ontanj/tanstack-query
that referenced
this issue
Apr 24, 2024
Rename CommonJS files in codemods to distinguish them from ES module files otherwise used in this project. Resolve an issue occuring since package.json in codemods is removed when publishing causing module type data to be lost. Fix issue TanStack#7154
lachlancollins
added a commit
that referenced
this issue
Apr 25, 2024
* bug(codemods): rename CommonJS files to .cjs Rename CommonJS files in codemods to distinguish them from ES module files otherwise used in this project. Resolve an issue occuring since package.json in codemods is removed when publishing causing module type data to be lost. Fix issue #7154 * Fix knip errors * Add file extension to tests * Update migration doc --------- Co-authored-by: Lachlan Collins <[email protected]>
Fixed in #7333 |
Thanks for the fix! Would you mind releasing a version that includes it? Cheers! |
it should've been in 5.32.1 not sure why that hasn't been released... checking ... |
Thanks @TkDodo , very much appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
ERR_REQUIRE_ESM when migrating from v4 to v5 with codegen
Your minimal, reproducible example
NA
Steps to reproduce
Running this
gives this error:
Expected behavior
No error
How often does this bug happen?
None
Screenshots or Videos
No response
Platform
macos
Tanstack Query adapter
None
TanStack Query version
5.28.6
TypeScript version
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: