Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade storybook #964

Merged
merged 2 commits into from
Jan 8, 2018
Merged

Conversation

jsomsanith-tlnd
Copy link
Contributor

What is the problem this PR is trying to solve?
With the current version (3.2.0) of storybook (addon-actions), there is an issue when passing events in action() callbacks. Storybook hangs for several seconds :/
More details here : storybookjs/storybook#778

What is the chosen solution to this problem?
Upgrade storybook to ^3.3.6, the fix is released since 3.3.0.

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@frassinier frassinier merged commit b84b817 into master Jan 8, 2018
@frassinier frassinier deleted the jsomsanith/chore/upgrade-storybook branch January 8, 2018 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants