Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the front controller to use a ResourceResolver so not all possible routes need to be mapped #1097

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

matthijsln
Copy link
Contributor

@matthijsln matthijsln commented Dec 20, 2024

HTM-1382 Powered by Pull Request Badge

So extensions aren't restricted to only use /ext/, but can also use routes like /portal/ or /page/.

@matthijsln matthijsln added the enhancement New feature or request label Dec 20, 2024
@matthijsln matthijsln self-assigned this Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

Test Results

300 tests  ±0   298 ✅ ±0   3m 37s ⏱️ -5s
 32 suites ±0     2 💤 ±0 
 32 files   ±0     0 ❌ ±0 

Results for commit 25c21d7. ± Comparison against base commit 7cbf798.

♻️ This comment has been updated with latest results.

@matthijsln matthijsln force-pushed the HTM-1382/improve-front-controller branch from bc3da1c to 25c21d7 Compare December 20, 2024 18:23
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 24 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pi/configuration/base/FrontControllerResolver.java 38% 14 Missing and 6 partials ⚠️
...p/api/configuration/base/IndexHtmlTransformer.java 0% 4 Missing ⚠️

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #1097   +/-   ##
======================================
+ Coverage      77%     77%   +1%     
  Complexity     87      87           
======================================
  Files         116     116           
  Lines        5593    5595    +2     
  Branches      482     486    +4     
======================================
+ Hits         4279    4282    +3     
+ Misses       1064    1057    -7     
- Partials      250     256    +6     
Files with missing lines Coverage Δ Complexity Δ
...tailormap/api/configuration/base/WebMvcConfig.java 100% <100%> (ø) 0 <0> (ø)
...p/api/configuration/base/IndexHtmlTransformer.java 34% <0%> (-8%) 0 <0> (ø)
...pi/configuration/base/FrontControllerResolver.java 38% <38%> (ø) 0 <0> (?)

@mprins mprins merged commit 8c8f5e8 into main Dec 21, 2024
25 of 26 checks passed
@mprins mprins deleted the HTM-1382/improve-front-controller branch December 21, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants