fix: ui/ux parity fixes for thumbnails and files #608
Conversation
CyanVoxel
added
Type: Bug
| item_thumb.set_mode(ItemType.ENTRY) | ||
| item_thumb.set_item_id(entry) | ||
|
|
||
| # TODO - show after item is rendered | ||
| item_thumb.show() | ||
|
|
||
| is_loading = True |
There was a problem hiding this comment.
could this not be hardcoded? As far as I can tell this is never changed and only accessed once
(same in the next loop)
There was a problem hiding this comment.
It can be hard-coded, but the reason I split it off into a variable is due to the way the arguments are being passed where I'm unable to use named parameters. It took some time to sort out which of the existing unnamed boolean arguments were doing what here, so I opted to store them in named variables for clarity.
| @@ -1187,7 +1203,8 @@ def open_library(self, path: Path) -> LibraryStatus: | |||
| self.filter.page_size = self.lib.prefs(LibraryPrefs.PAGE_SIZE) | |||
|
|
|||
| # TODO - make this call optional | |||
| self.add_new_files_callback() | |||
| if self.lib.entries_count < 10000: | |||
| self.add_new_files_callback() | |||
There was a problem hiding this comment.
Is this change what the todo refers to? If so can it be removed?
There was a problem hiding this comment.
I left the TODO here since while it originally referred to the persistent call, it still works as a TODO to add the option to customize the new threshold here.
* fix: mypy error in ts_qt * fix: mypy error in file_opener due to conflicting types * fix: remove unnecessary type ignores * refix type ignore comments * partially revert "refix type ignore comments" due to being implemented in #608
|
Sorry for the couple of late additions. I've fixed the default text for certain preview panel labels to correctly be assigned to the object names themselves, as well as fixed an issue with unlinked thumbnails not always rendering + quieted down some of the logs. |
This PR adds various fixes and improvements for increased parity of thumbnail and file entry behavior between v9.4 and v9.5. This includes: